Make codereview.setting syntax more liberal and add more unit tests.

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 173 matching lines @@
   if '__just_initialized' not in CODEREVIEW_SETTINGS:
     settings_file = GetCachedFile(CODEREVIEW_SETTINGS_FILE)
     if settings_file:
       for line in settings_file.splitlines():
         if not line or line.startswith('#'):
           continue
         if not ':' in line:
           raise gclient_utils.Error(
               '%s is invalid, please fix. It\'s content:\n\n%s' %
                   (CODEREVIEW_SETTINGS_FILE, settings_file))
-        k, v = line.split(': ', 1)
-        CODEREVIEW_SETTINGS[k] = v
+        k, v = line.split(':', 1)
+        CODEREVIEW_SETTINGS[k.strip()] = v.strip()
     CODEREVIEW_SETTINGS.setdefault('__just_initialized', None)
   return CODEREVIEW_SETTINGS.get(key, "")
 
 
 def Warn(msg):
   print >> sys.stderr, msg
 
 
 def ErrorExit(msg):
   print >> sys.stderr, msg
@@ skipping 1114 matching lines @@
     if command:
       return command(argv[1:])
     # Unknown command, try to pass that to svn
     return CMDpassthru(argv)
   except gclient_utils.Error, e:
     print('Got an exception')
     print(str(e))
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))