gcl.py - Issue 3140023: Make codereview.setting syntax more liberal and add more unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 3140023: Make codereview.setting syntax more liberal and add more unit tests. (Closed)

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 8c89a7a049948c7f458bea55a200d89357ba4c48..6726d028b598d8243100d7d12ef0446c7dacd4a7 100755

--- a/gcl.py

+++ b/gcl.py

@@ -191,8 +191,8 @@ def GetCodeReviewSetting(key):

raise gclient_utils.Error(

'%s is invalid, please fix. It\'s content:\n\n%s' %

(CODEREVIEW_SETTINGS_FILE, settings_file))

- k, v = line.split(': ', 1)

- CODEREVIEW_SETTINGS[k] = v

+ k, v = line.split(':', 1)

+ CODEREVIEW_SETTINGS[k.strip()] = v.strip()

CODEREVIEW_SETTINGS.setdefault('__just_initialized', None)

return CODEREVIEW_SETTINGS.get(key, "")

« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | no next file with comments »