Issue 3120011: LiveEdit: implement stack manipulations for x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3120011: LiveEdit: implement stack manipulations for x64 (Closed)

Created:
10 years, 4 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

LiveEdit: implement stack manipulations for x64 Committed: http://code.google.com/p/v8/source/detail?r=5264

Patch Set 3 : follow codereview #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -60 lines)			Patch
M	src/arm/debug-arm.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/debug.h	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/debug.cc	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/ia32/debug-ia32.cc	View		2 chunks	+2 lines, -32 lines	0 comments	Download
M	src/liveedit.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/debug-mips.cc	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	1 2	1 chunk	+24 lines, -8 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

Hi Soren I additionally move one function into arch-independent part. Peter

10 years, 4 months ago (2010-08-12 19:59:55 UTC) #1

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/3120011/diff/2001/3007 File src/x64/debug-x64.cc (right): http://codereview.chromium.org/3120011/diff/2001/3007#newcode215 src/x64/debug-x64.cc:215: // We do not know our frame height, ...

10 years, 4 months ago (2010-08-13 06:56:45 UTC) #2

Peter Rybin

10 years, 4 months ago (2010-08-13 13:06:09 UTC) #3

http://codereview.chromium.org/3120011/diff/2001/3007
File src/x64/debug-x64.cc (right):

http://codereview.chromium.org/3120011/diff/2001/3007#newcode215
src/x64/debug-x64.cc:215: // We do not know our frame height, but set esp based
on ebp.
On 2010/08/13 06:56:45, Søren Gjesse wrote:
> esp -> rsp

Done.

Expand Messages | Collapse Messages

Issue 3120011: LiveEdit: implement stack manipulations for x64 (Closed)

Description

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : follow codereview #

Messages