Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: src/x64/debug-x64.cc

Issue 3120011: LiveEdit: implement stack manipulations for x64 (Closed)
Patch Set: follow codereview Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/debug-mips.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 195
196 196
197 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) { 197 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) {
198 // In the places where a debug break slot is inserted no registers can contain 198 // In the places where a debug break slot is inserted no registers can contain
199 // object pointers. 199 // object pointers.
200 Generate_DebugBreakCallHelper(masm, 0, true); 200 Generate_DebugBreakCallHelper(masm, 0, true);
201 } 201 }
202 202
203 203
204 void Debug::GeneratePlainReturnLiveEdit(MacroAssembler* masm) { 204 void Debug::GeneratePlainReturnLiveEdit(MacroAssembler* masm) {
205 masm->Abort("LiveEdit frame dropping is not supported on x64"); 205 masm->ret(0);
206 } 206 }
207 207
208 208
209 void Debug::GenerateFrameDropperLiveEdit(MacroAssembler* masm) { 209 void Debug::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {
210 masm->Abort("LiveEdit frame dropping is not supported on x64"); 210 ExternalReference restarter_frame_function_slot =
211 ExternalReference(Debug_Address::RestarterFrameFunctionPointer());
212 __ movq(rax, restarter_frame_function_slot);
213 __ movq(Operand(rax, 0), Immediate(0));
214
215 // We do not know our frame height, but set rsp based on rbp.
216 __ lea(rsp, Operand(rbp, -1 * kPointerSize));
217
218 __ pop(rdi); // Function.
219 __ pop(rbp);
220
221 // Load context from the function.
222 __ movq(rsi, FieldOperand(rdi, JSFunction::kContextOffset));
223
224 // Get function code.
225 __ movq(rdx, FieldOperand(rdi, JSFunction::kSharedFunctionInfoOffset));
226 __ movq(rdx, FieldOperand(rdx, SharedFunctionInfo::kCodeOffset));
227 __ lea(rdx, FieldOperand(rdx, Code::kHeaderSize));
228
229 // Re-run JSFunction, rdi is function, rsi is context.
230 __ jmp(rdx);
211 } 231 }
212 232
233 const bool Debug::kFrameDropperSupported = true;
234
213 #undef __ 235 #undef __
214 236
215 237
216 Object** Debug::SetUpFrameDropperFrame(StackFrame* bottom_js_frame,
217 Handle<Code> code) {
218 UNREACHABLE();
219 return NULL;
220 }
221 const int Debug::kFrameDropperFrameSize = -1;
222 238
223 239
224 void BreakLocationIterator::ClearDebugBreakAtReturn() { 240 void BreakLocationIterator::ClearDebugBreakAtReturn() {
225 rinfo()->PatchCode(original_rinfo()->pc(), 241 rinfo()->PatchCode(original_rinfo()->pc(),
226 Assembler::kJSReturnSequenceLength); 242 Assembler::kJSReturnSequenceLength);
227 } 243 }
228 244
229 245
230 bool BreakLocationIterator::IsDebugBreakAtReturn() { 246 bool BreakLocationIterator::IsDebugBreakAtReturn() {
231 return Debug::IsDebugBreakAtReturn(rinfo()); 247 return Debug::IsDebugBreakAtReturn(rinfo());
(...skipping 27 matching lines...) Expand all
259 ASSERT(IsDebugBreakSlot()); 275 ASSERT(IsDebugBreakSlot());
260 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength); 276 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength);
261 } 277 }
262 278
263 279
264 #endif // ENABLE_DEBUGGER_SUPPORT 280 #endif // ENABLE_DEBUGGER_SUPPORT
265 281
266 } } // namespace v8::internal 282 } } // namespace v8::internal
267 283
268 #endif // V8_TARGET_ARCH_X64 284 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/debug-mips.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698