Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: src/liveedit.cc

Issue 3120011: LiveEdit: implement stack manipulations for x64 (Closed)
Patch Set: follow codereview Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 1199
1200 // Removes specified range of frames from stack. There may be 1 or more 1200 // Removes specified range of frames from stack. There may be 1 or more
1201 // frames in range. Anyway the bottom frame is restarted rather than dropped, 1201 // frames in range. Anyway the bottom frame is restarted rather than dropped,
1202 // and therefore has to be a JavaScript frame. 1202 // and therefore has to be a JavaScript frame.
1203 // Returns error message or NULL. 1203 // Returns error message or NULL.
1204 static const char* DropFrames(Vector<StackFrame*> frames, 1204 static const char* DropFrames(Vector<StackFrame*> frames,
1205 int top_frame_index, 1205 int top_frame_index,
1206 int bottom_js_frame_index, 1206 int bottom_js_frame_index,
1207 Debug::FrameDropMode* mode, 1207 Debug::FrameDropMode* mode,
1208 Object*** restarter_frame_function_pointer) { 1208 Object*** restarter_frame_function_pointer) {
1209 if (Debug::kFrameDropperFrameSize < 0) { 1209 if (!Debug::kFrameDropperSupported) {
1210 return "Stack manipulations are not supported in this architecture."; 1210 return "Stack manipulations are not supported in this architecture.";
1211 } 1211 }
1212 1212
1213 StackFrame* pre_top_frame = frames[top_frame_index - 1]; 1213 StackFrame* pre_top_frame = frames[top_frame_index - 1];
1214 StackFrame* top_frame = frames[top_frame_index]; 1214 StackFrame* top_frame = frames[top_frame_index];
1215 StackFrame* bottom_js_frame = frames[bottom_js_frame_index]; 1215 StackFrame* bottom_js_frame = frames[bottom_js_frame_index];
1216 1216
1217 ASSERT(bottom_js_frame->is_java_script()); 1217 ASSERT(bottom_js_frame->is_java_script());
1218 1218
1219 // Check the nature of the top frame. 1219 // Check the nature of the top frame.
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
1494 1494
1495 bool LiveEditFunctionTracker::IsActive() { 1495 bool LiveEditFunctionTracker::IsActive() {
1496 return false; 1496 return false;
1497 } 1497 }
1498 1498
1499 #endif // ENABLE_DEBUGGER_SUPPORT 1499 #endif // ENABLE_DEBUGGER_SUPPORT
1500 1500
1501 1501
1502 1502
1503 } } // namespace v8::internal 1503 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698