Issue 3113028: Remove wstrings from bookmarks, part 8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3113028: Remove wstrings from bookmarks, part 8. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Nico, Miranda Callahan

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Remove wstrings from bookmarks, part 8. Convert lots of uses of the wstring BookmarkNode::GetTitle() in browser/cocoa. BUG=23581 TEST=builds and passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56996

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -35 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_controller.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller_unittest.mm	View	6 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bubble_controller.mm	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_button_cell.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_base_controller.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller_unittest.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_folder_target.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_menu_bridge.mm	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_name_folder_controller.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/cookie_tree_node.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Miranda Callahan

10 years, 4 months ago (2010-08-21 16:39:34 UTC) #2

On 2010/08/21 16:23:10, viettrungluu wrote:
> 

lgtm