Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Issue 3113028: Remove wstrings from bookmarks, part 8. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/string16.h" 7 #include "base/string16.h"
8 #include "base/sys_string_conversions.h" 8 #include "base/sys_string_conversions.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 const BookmarkNode* child = default_parent_->GetChild(0); 54 const BookmarkNode* child = default_parent_->GetChild(0);
55 EXPECT_EQ(child->GetTitleAsString16(), default_title_); 55 EXPECT_EQ(child->GetTitleAsString16(), default_title_);
56 EXPECT_EQ(child->GetURL(), GURL(default_name_)); 56 EXPECT_EQ(child->GetURL(), GURL(default_name_));
57 } 57 }
58 58
59 TEST_F(BookmarkEditorControllerTest, EditTitle) { 59 TEST_F(BookmarkEditorControllerTest, EditTitle) {
60 [controller_ setDisplayName:@"whamma jamma bamma"]; 60 [controller_ setDisplayName:@"whamma jamma bamma"];
61 [controller_ ok:nil]; 61 [controller_ ok:nil];
62 ASSERT_EQ(default_parent_->GetChildCount(), 1); 62 ASSERT_EQ(default_parent_->GetChildCount(), 1);
63 const BookmarkNode* child = default_parent_->GetChild(0); 63 const BookmarkNode* child = default_parent_->GetChild(0);
64 EXPECT_EQ(child->GetTitle(), L"whamma jamma bamma"); 64 EXPECT_EQ(child->GetTitleAsString16(), ASCIIToUTF16("whamma jamma bamma"));
65 EXPECT_EQ(child->GetURL(), GURL(default_name_)); 65 EXPECT_EQ(child->GetURL(), GURL(default_name_));
66 } 66 }
67 67
68 TEST_F(BookmarkEditorControllerTest, EditURL) { 68 TEST_F(BookmarkEditorControllerTest, EditURL) {
69 EXPECT_TRUE([controller_ okButtonEnabled]); 69 EXPECT_TRUE([controller_ okButtonEnabled]);
70 [controller_ setDisplayURL:@"http://yellow-sneakers.com/"]; 70 [controller_ setDisplayURL:@"http://yellow-sneakers.com/"];
71 EXPECT_TRUE([controller_ okButtonEnabled]); 71 EXPECT_TRUE([controller_ okButtonEnabled]);
72 [controller_ ok:nil]; 72 [controller_ ok:nil];
73 ASSERT_EQ(default_parent_->GetChildCount(), 1); 73 ASSERT_EQ(default_parent_->GetChildCount(), 1);
74 const BookmarkNode* child = default_parent_->GetChild(0); 74 const BookmarkNode* child = default_parent_->GetChild(0);
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 TEST_F(BookmarkEditorControllerTreeTest, ChangeNameAndBookmarkGroup) { 382 TEST_F(BookmarkEditorControllerTreeTest, ChangeNameAndBookmarkGroup) {
383 [controller_ setDisplayName:@"NEW NAME"]; 383 [controller_ setDisplayName:@"NEW NAME"];
384 [controller_ selectTestNodeInBrowser:group_c_]; 384 [controller_ selectTestNodeInBrowser:group_c_];
385 [controller_ ok:nil]; 385 [controller_ ok:nil];
386 UpdateBB3(); 386 UpdateBB3();
387 const BookmarkNode* parent = bookmark_bb_3_->GetParent(); 387 const BookmarkNode* parent = bookmark_bb_3_->GetParent();
388 ASSERT_EQ(parent, group_c_); 388 ASSERT_EQ(parent, group_c_);
389 int childIndex = parent->IndexOfChild(bookmark_bb_3_); 389 int childIndex = parent->IndexOfChild(bookmark_bb_3_);
390 ASSERT_EQ(4, childIndex); 390 ASSERT_EQ(4, childIndex);
391 EXPECT_EQ(bookmark_bb_3_->GetTitle(), L"NEW NAME"); 391 EXPECT_EQ(bookmark_bb_3_->GetTitleAsString16(), ASCIIToUTF16("NEW NAME"));
392 } 392 }
393 393
394 TEST_F(BookmarkEditorControllerTreeTest, AddFolderWithGroupSelected) { 394 TEST_F(BookmarkEditorControllerTreeTest, AddFolderWithGroupSelected) {
395 // Folders are NOT added unless the OK button is pressed. 395 // Folders are NOT added unless the OK button is pressed.
396 [controller_ newFolder:nil]; 396 [controller_ newFolder:nil];
397 [controller_ cancel:nil]; 397 [controller_ cancel:nil];
398 EXPECT_EQ(5, group_bb_->GetChildCount()); 398 EXPECT_EQ(5, group_bb_->GetChildCount());
399 } 399 }
400 400
401 class BookmarkEditorControllerTreeNoNodeTest : 401 class BookmarkEditorControllerTreeNoNodeTest :
402 public BookmarkEditorControllerTreeTest { 402 public BookmarkEditorControllerTreeTest {
403 public: 403 public:
404 virtual BookmarkEditorController* CreateController() { 404 virtual BookmarkEditorController* CreateController() {
405 return [[BookmarkEditorController alloc] 405 return [[BookmarkEditorController alloc]
406 initWithParentWindow:test_window() 406 initWithParentWindow:test_window()
407 profile:browser_helper_.profile() 407 profile:browser_helper_.profile()
408 parent:group_bb_ 408 parent:group_bb_
409 node:nil 409 node:nil
410 configuration:BookmarkEditor::SHOW_TREE]; 410 configuration:BookmarkEditor::SHOW_TREE];
411 } 411 }
412 412
413 }; 413 };
414 414
415 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) { 415 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) {
416 [controller_ setDisplayName:@"NEW BOOKMARK"]; 416 [controller_ setDisplayName:@"NEW BOOKMARK"];
417 [controller_ setDisplayURL:@"http://NEWURL.com"]; 417 [controller_ setDisplayURL:@"http://NEWURL.com"];
418 [controller_ ok:nil]; 418 [controller_ ok:nil];
419 const BookmarkNode* new_node = group_bb_->GetChild(5); 419 const BookmarkNode* new_node = group_bb_->GetChild(5);
420 ASSERT_EQ(0, new_node->GetChildCount()); 420 ASSERT_EQ(0, new_node->GetChildCount());
421 EXPECT_EQ(new_node->GetTitle(), L"NEW BOOKMARK"); 421 EXPECT_EQ(new_node->GetTitleAsString16(), ASCIIToUTF16("NEW BOOKMARK"));
422 EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com")); 422 EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com"));
423 } 423 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | chrome/browser/cocoa/bookmark_folder_target.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698