Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Issue 3113028: Remove wstrings from bookmarks, part 8. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
diff --git a/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm b/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
index 494b58d0ff8dec3e25bb01783d0db288eb6d0e44..b04455e1f7f5acbcd0720500c5ecc61b57443c4a 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
+++ b/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
@@ -1014,11 +1014,11 @@ TEST_F(BookmarkBarControllerTest, DropBookmarks) {
"javascript:alert('lolwut')",
"file://localhost/tmp/local-file.txt" // As if dragged from the desktop.
};
- std::wstring titles[] = {
- std::wstring(L"Philosophoraptor"),
- std::wstring(L"Can't draw"),
- std::wstring(L"Inspiration"),
- std::wstring(L"Frum stuf")
+ const char* titles[] = {
+ "Philosophoraptor",
+ "Can't draw",
+ "Inspiration",
+ "Frum stuf"
};
EXPECT_EQ(arraysize(urls), arraysize(titles));
@@ -1026,7 +1026,7 @@ TEST_F(BookmarkBarControllerTest, DropBookmarks) {
NSMutableArray* nstitles = [NSMutableArray array];
for (size_t i = 0; i < arraysize(urls); ++i) {
[nsurls addObject:base::SysUTF8ToNSString(urls[i])];
- [nstitles addObject:base::SysWideToNSString(titles[i])];
+ [nstitles addObject:base::SysUTF8ToNSString(titles[i])];
}
BookmarkModel* model = helper_.profile()->GetBookmarkModel();
@@ -1044,7 +1044,8 @@ TEST_F(BookmarkBarControllerTest, DropBookmarks) {
std::string my_string = parent->GetChild(i)->GetURL().spec();
EXPECT_NE(gurl_string.find(my_string), std::string::npos);
}
- EXPECT_EQ(parent->GetChild(i)->GetTitle(), titles[i]);
+ EXPECT_EQ(parent->GetChild(i)->GetTitleAsString16(),
+ ASCIIToUTF16(titles[i]));
}
}
@@ -1166,8 +1167,8 @@ TEST_F(BookmarkBarControllerTest, TestDragButton) {
EXPECT_EQ(1, folder->GetChildCount());
x = NSMidX([[[bar_ buttons] objectAtIndex:0] frame]);
x += [[bar_ view] frame].origin.x;
- std::wstring title = [[[bar_ buttons] objectAtIndex:2]
- bookmarkNode]->GetTitle();
+ string16 title =
+ [[[bar_ buttons] objectAtIndex:2] bookmarkNode]->GetTitleAsString16();
[bar_ dragButton:[[bar_ buttons] objectAtIndex:2]
to:NSMakePoint(x, 0)
copy:NO];
@@ -1176,7 +1177,7 @@ TEST_F(BookmarkBarControllerTest, TestDragButton) {
// In the folder
EXPECT_EQ(2, folder->GetChildCount());
// At the end
- EXPECT_EQ(title, folder->GetChild(1)->GetTitle());
+ EXPECT_EQ(title, folder->GetChild(1)->GetTitleAsString16());
}
TEST_F(BookmarkBarControllerTest, TestCopyButton) {
@@ -1947,7 +1948,7 @@ TEST_F(BookmarkBarControllerDragDropTest, DragBookmarkData) {
ASSERT_TRUE(targetButton);
NSPoint targetPoint = [targetButton center];
newNode = other->GetChild(2); // Should be O4f.
- EXPECT_EQ(newNode->GetTitle(), L"O4f");
+ EXPECT_EQ(newNode->GetTitleAsString16(), ASCIIToUTF16("O4f"));
[bar_ setDragDataNode:newNode];
[dragInfo setDropLocation:targetPoint];
[bar_ dragBookmarkData:(id<NSDraggingInfo>)dragInfo.get()];
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_controller.mm ('k') | chrome/browser/cocoa/bookmark_bar_folder_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698