Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm

Issue 3113028: Remove wstrings from bookmarks, part 8. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/cocoa/bookmark_menu_cocoa_controller.h" 5 #import "chrome/browser/cocoa/bookmark_menu_cocoa_controller.h"
6 6
7 #include "app/text_elider.h" 7 #include "app/text_elider.h"
8 #include "base/sys_string_conversions.h" 8 #include "base/sys_string_conversions.h"
9 #include "base/utf_string_conversions.h"
9 #include "chrome/app/chrome_dll_resource.h" // IDC_BOOKMARK_MENU 10 #include "chrome/app/chrome_dll_resource.h" // IDC_BOOKMARK_MENU
10 #import "chrome/browser/app_controller_mac.h" 11 #import "chrome/browser/app_controller_mac.h"
11 #include "chrome/browser/bookmarks/bookmark_model.h" 12 #include "chrome/browser/bookmarks/bookmark_model.h"
12 #include "chrome/browser/browser.h" 13 #include "chrome/browser/browser.h"
13 #import "chrome/browser/cocoa/bookmark_menu_bridge.h" 14 #import "chrome/browser/cocoa/bookmark_menu_bridge.h"
14 #include "chrome/browser/cocoa/event_utils.h" 15 #include "chrome/browser/cocoa/event_utils.h"
15 #include "chrome/browser/browser_process.h" 16 #include "chrome/browser/browser_process.h"
16 #include "chrome/browser/tab_contents/tab_contents.h" 17 #include "chrome/browser/tab_contents/tab_contents.h"
17 #include "webkit/glue/window_open_disposition.h" 18 #include "webkit/glue/window_open_disposition.h"
18 19
19 namespace { 20 namespace {
20 21
21 // Menus more than this many pixels wide will get trimmed 22 // Menus more than this many pixels wide will get trimmed
22 // TODO(jrg): ask UI dudes what a good value is. 23 // TODO(jrg): ask UI dudes what a good value is.
23 const NSUInteger kMaximumMenuPixelsWide = 300; 24 const NSUInteger kMaximumMenuPixelsWide = 300;
24 25
25 } 26 }
26 27
27 @implementation BookmarkMenuCocoaController 28 @implementation BookmarkMenuCocoaController
28 29
29 + (NSString*)menuTitleForNode:(const BookmarkNode*)node { 30 + (NSString*)menuTitleForNode:(const BookmarkNode*)node {
30 NSFont* nsfont = [NSFont menuBarFontOfSize:0]; // 0 means "default" 31 NSFont* nsfont = [NSFont menuBarFontOfSize:0]; // 0 means "default"
31 gfx::Font font(base::SysNSStringToWide([nsfont fontName]), 32 gfx::Font font(base::SysNSStringToWide([nsfont fontName]),
32 static_cast<int>([nsfont pointSize])); 33 static_cast<int>([nsfont pointSize]));
33 std::wstring title = gfx::ElideText(node->GetTitle(), 34 std::wstring title = gfx::ElideText(UTF16ToWideHack(
35 node->GetTitleAsString16()),
34 font, 36 font,
35 kMaximumMenuPixelsWide, 37 kMaximumMenuPixelsWide,
36 false); 38 false);
37 return base::SysWideToNSString(title); 39 return base::SysWideToNSString(title);
38 } 40 }
39 41
40 - (id)initWithBridge:(BookmarkMenuBridge *)bridge { 42 - (id)initWithBridge:(BookmarkMenuBridge *)bridge {
41 if ((self = [super init])) { 43 if ((self = [super init])) {
42 bridge_ = bridge; 44 bridge_ = bridge;
43 DCHECK(bridge_); 45 DCHECK(bridge_);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 const BookmarkNode* node = [self nodeForIdentifier:identifier]; 89 const BookmarkNode* node = [self nodeForIdentifier:identifier];
88 DCHECK(node); 90 DCHECK(node);
89 if (!node) 91 if (!node)
90 return; // shouldn't be reached 92 return; // shouldn't be reached
91 93
92 [self openURLForNode:node]; 94 [self openURLForNode:node];
93 } 95 }
94 96
95 @end // BookmarkMenuCocoaController 97 @end // BookmarkMenuCocoaController
96 98
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/bookmark_menu_bridge.mm ('k') | chrome/browser/cocoa/bookmark_name_folder_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698