[Mac] Use the new {EXPECT,ASSERT}_NS{EQ,NE} macros where possible.

[Mac] Use the new {EXPECT,ASSERT}_NS{EQ,NE} macros in unit tests where possible.

BUG=none
TEST=unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55280

[Mark Mentovai, 2010-08-05 23:15:15]

LG o.

http://codereview.chromium.org/3095004/diff/1/5
File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/1/5#newcode936
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:936: EXPECT_NSEQ([cell
title], @"supertitle");
order?

http://codereview.chromium.org/3095004/diff/1/5#newcode1116
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:1116:
EXPECT_NSEQ([[[bar_ buttons] objectAtIndex:0] title], @"a");
…order…

http://codereview.chromium.org/3095004/diff/1/8
File chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/1/8#newcode158
chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm:158:
EXPECT_NSEQ(newFolderName, expectedName);
Doesn’t gtest like to put the expected before the observed?

Seems like this happens in a few other cases too.

http://codereview.chromium.org/3095004/diff/1/9
File chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/1/9#newcode198
chrome/browser/cocoa/bookmark_editor_controller_unittest.mm:198: [controller_
displayURL]);
Fix indentation.

http://codereview.chromium.org/3095004/diff/1/11
File chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/1/11#newcode137
chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm:137:
EXPECT_NSEQ([controller folderName], @"group");
order?

http://codereview.chromium.org/3095004/diff/1/12
File chrome/browser/cocoa/browser_accessibility_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/1/12#newcode84
chrome/browser/cocoa/browser_accessibility_unittest.mm:84: [firstChild
accessibilityAttributeValue:NSAccessibilityTitleAttribute],
I’m gonna stop saying order, but first:

“order?”

http://codereview.chromium.org/3095004/diff/1/31
File chrome/browser/cocoa/tab_view_picker_table_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/1/31#newcode105
chrome/browser/cocoa/tab_view_picker_table_unittest.mm:105: outlineView:view_
Really awkward.

http://codereview.chromium.org/3095004/diff/1/31#newcode110
chrome/browser/cocoa/tab_view_picker_table_unittest.mm:110: outlineView:view_
Bet you can do better.

[Robert Sesek, 2010-08-06 18:48:20]

Fixed a bunch of ordering issues and indention stuff.

[Mark Mentovai, 2010-08-06 20:01:01]

LGTM

http://codereview.chromium.org/3095004/diff/12001/1037
File chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/12001/1037#newcode322
chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm:322:
EXPECT_NSEQ(itemObject, [NSValue valueWithPointer:node1]);
I think that this and the one on line 326 should be reversed.

http://codereview.chromium.org/3095004/diff/12001/1039
File chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/12001/1039#newcode122
chrome/browser/cocoa/bookmark_editor_controller_unittest.mm:122:
EXPECT_NSNE(urlColorB, urlColorA);
Reverse (if for no reason other than that A-B makes more sense than B-A)? 127
too.

http://codereview.chromium.org/3095004/diff/12001/1057
File chrome/browser/cocoa/preferences_window_controller_unittest.mm (right):

http://codereview.chromium.org/3095004/diff/12001/1057#newcode203
chrome/browser/cocoa/preferences_window_controller_unittest.mm:203:
EXPECT_NSEQ([window title], [basicsToolbarItem label]);
Reverse? Also on 211, 219, and 230.