Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2603)

Unified Diff: chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm

Issue 3095004: [Mac] Use the new {EXPECT,ASSERT}_NS{EQ,NE} macros where possible. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Fix compile Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
diff --git a/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm b/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
index 47585aa68fe8037936f85babad7dba36849f81f5..219131017763b628c2e8c2f6de835b88d6b8d36b 100644
--- a/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
+++ b/chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm
@@ -10,6 +10,7 @@
#include "chrome/browser/cocoa/bookmark_menu_bridge.h"
#include "chrome/browser/cocoa/browser_test_helper.h"
#include "testing/gtest/include/gtest/gtest.h"
+#import "testing/gtest_mac.h"
#include "testing/platform_test.h"
class TestBookmarkMenuBridge : public BookmarkMenuBridge {
@@ -113,7 +114,7 @@ TEST_F(BookmarkMenuBridgeTest, TestClearBookmarkMenu) {
// submenus removed, and all separator items are gone.
EXPECT_EQ(2, [menu numberOfItems]);
for (NSMenuItem *item in [menu itemArray]) {
- EXPECT_FALSE([[item title] isEqual:@"not"]);
+ EXPECT_NSNE(@"not", [item title]);
}
}
@@ -203,7 +204,7 @@ TEST_F(BookmarkMenuBridgeTest, TestAddNodeToMenu) {
// Make sure a short title looks fine
NSString* s = [short_item title];
- EXPECT_TRUE([s isEqual:[NSString stringWithUTF8String:short_url]]);
+ EXPECT_NSEQ([NSString stringWithUTF8String:short_url], s);
// Make sure a super-long title gets trimmed
s = [long_item title];
@@ -271,7 +272,7 @@ TEST_F(BookmarkMenuBridgeTest, TestAddNodeToOther) {
EXPECT_TRUE(other);
EXPECT_TRUE([other hasSubmenu]);
ASSERT_GT([[other submenu] numberOfItems], 0);
- EXPECT_TRUE([[[[other submenu] itemAtIndex:0] title] isEqual:@"http://foo/"]);
+ EXPECT_NSEQ(@"http://foo/", [[[other submenu] itemAtIndex:0] title]);
}
TEST_F(BookmarkMenuBridgeTest, TestFavIconLoading) {

Powered by Google App Engine
This is Rietveld 408576698