Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #import <Cocoa/Cocoa.h> | 5 #import <Cocoa/Cocoa.h> |
| 6 | 6 |
| 7 #include "base/sys_string_conversions.h" | 7 #include "base/sys_string_conversions.h" |
| 8 #import "chrome/browser/cocoa/bookmark_editor_controller.h" | 8 #import "chrome/browser/cocoa/bookmark_editor_controller.h" |
| 9 #include "chrome/browser/cocoa/browser_test_helper.h" | 9 #include "chrome/browser/cocoa/browser_test_helper.h" |
| 10 #import "chrome/browser/cocoa/cocoa_test_helper.h" | 10 #import "chrome/browser/cocoa/cocoa_test_helper.h" |
| 11 #include "testing/gtest/include/gtest/gtest.h" | 11 #include "testing/gtest/include/gtest/gtest.h" |
| 12 #import "testing/gtest_mac.h" | |
| 12 #include "testing/platform_test.h" | 13 #include "testing/platform_test.h" |
| 13 | 14 |
| 14 class BookmarkEditorControllerTest : public CocoaTest { | 15 class BookmarkEditorControllerTest : public CocoaTest { |
| 15 public: | 16 public: |
| 16 BrowserTestHelper browser_helper_; | 17 BrowserTestHelper browser_helper_; |
| 17 const BookmarkNode* default_node_; | 18 const BookmarkNode* default_node_; |
| 18 const BookmarkNode* default_parent_; | 19 const BookmarkNode* default_parent_; |
| 19 const char* default_name_; | 20 const char* default_name_; |
| 20 std::wstring default_title_; | 21 std::wstring default_title_; |
| 21 BookmarkEditorController* controller_; | 22 BookmarkEditorController* controller_; |
| (...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 111 | 112 |
| 112 TEST_F(BookmarkEditorControllerTest, GoodAndBadURLsChangeColor) { | 113 TEST_F(BookmarkEditorControllerTest, GoodAndBadURLsChangeColor) { |
| 113 // Confirm that the background color of the URL edit field changes | 114 // Confirm that the background color of the URL edit field changes |
| 114 // based on whether it contains a valid or invalid URL. | 115 // based on whether it contains a valid or invalid URL. |
| 115 [controller_ setDisplayURL:@"http://www.cnn.com"]; | 116 [controller_ setDisplayURL:@"http://www.cnn.com"]; |
| 116 NSColor *urlColorA = [controller_ urlFieldColor]; | 117 NSColor *urlColorA = [controller_ urlFieldColor]; |
| 117 EXPECT_TRUE(urlColorA); | 118 EXPECT_TRUE(urlColorA); |
| 118 [controller_ setDisplayURL:@""]; | 119 [controller_ setDisplayURL:@""]; |
| 119 NSColor *urlColorB = [controller_ urlFieldColor]; | 120 NSColor *urlColorB = [controller_ urlFieldColor]; |
| 120 EXPECT_TRUE(urlColorB); | 121 EXPECT_TRUE(urlColorB); |
| 121 EXPECT_FALSE([urlColorB isEqual:urlColorA]); | 122 EXPECT_NSNE(urlColorB, urlColorA); |
|
Mark Mentovai
2010/08/06 20:01:01
Reverse (if for no reason other than that A-B make
| |
| 122 [controller_ setDisplayURL:@"http://www.google.com"]; | 123 [controller_ setDisplayURL:@"http://www.google.com"]; |
| 123 [controller_ cancel:nil]; | 124 [controller_ cancel:nil]; |
| 124 urlColorB = [controller_ urlFieldColor]; | 125 urlColorB = [controller_ urlFieldColor]; |
| 125 EXPECT_TRUE(urlColorB); | 126 EXPECT_TRUE(urlColorB); |
| 126 EXPECT_TRUE([urlColorB isEqual:urlColorA]); | 127 EXPECT_NSEQ(urlColorB, urlColorA); |
| 127 } | 128 } |
| 128 | 129 |
| 129 class BookmarkEditorControllerNoNodeTest : public CocoaTest { | 130 class BookmarkEditorControllerNoNodeTest : public CocoaTest { |
| 130 public: | 131 public: |
| 131 BrowserTestHelper browser_helper_; | 132 BrowserTestHelper browser_helper_; |
| 132 BookmarkEditorController* controller_; | 133 BookmarkEditorController* controller_; |
| 133 | 134 |
| 134 virtual void SetUp() { | 135 virtual void SetUp() { |
| 135 CocoaTest::SetUp(); | 136 CocoaTest::SetUp(); |
| 136 BookmarkModel* model = browser_helper_.profile()->GetBookmarkModel(); | 137 BookmarkModel* model = browser_helper_.profile()->GetBookmarkModel(); |
| (...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 183 [controller_ runAsModalSheet]; | 184 [controller_ runAsModalSheet]; |
| 184 } | 185 } |
| 185 | 186 |
| 186 virtual void TearDown() { | 187 virtual void TearDown() { |
| 187 controller_ = NULL; | 188 controller_ = NULL; |
| 188 CocoaTest::TearDown(); | 189 CocoaTest::TearDown(); |
| 189 } | 190 } |
| 190 }; | 191 }; |
| 191 | 192 |
| 192 TEST_F(BookmarkEditorControllerYesNodeTest, YesNodeShowTree) { | 193 TEST_F(BookmarkEditorControllerYesNodeTest, YesNodeShowTree) { |
| 193 EXPECT_TRUE([base::SysWideToNSString(default_title_) | 194 EXPECT_NSEQ(base::SysWideToNSString(default_title_), |
| 194 isEqual:[controller_ displayName]]); | 195 [controller_ displayName]); |
| 195 EXPECT_TRUE([[NSString stringWithCString:url_name_ | 196 EXPECT_NSEQ([NSString stringWithCString:url_name_ |
| 196 encoding:NSUTF8StringEncoding] | 197 encoding:NSUTF8StringEncoding], |
| 197 isEqual:[controller_ displayURL]]); | 198 [controller_ displayURL]); |
| 198 [controller_ cancel:nil]; | 199 [controller_ cancel:nil]; |
| 199 } | 200 } |
| 200 | 201 |
| 201 class BookmarkEditorControllerTreeTest : public CocoaTest { | 202 class BookmarkEditorControllerTreeTest : public CocoaTest { |
| 202 | 203 |
| 203 public: | 204 public: |
| 204 BrowserTestHelper browser_helper_; | 205 BrowserTestHelper browser_helper_; |
| 205 BookmarkEditorController* controller_; | 206 BookmarkEditorController* controller_; |
| 206 const BookmarkNode* group_a_; | 207 const BookmarkNode* group_a_; |
| 207 const BookmarkNode* group_b_; | 208 const BookmarkNode* group_b_; |
| (...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 409 | 410 |
| 410 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) { | 411 TEST_F(BookmarkEditorControllerTreeNoNodeTest, NewBookmarkNoNode) { |
| 411 [controller_ setDisplayName:@"NEW BOOKMARK"]; | 412 [controller_ setDisplayName:@"NEW BOOKMARK"]; |
| 412 [controller_ setDisplayURL:@"http://NEWURL.com"]; | 413 [controller_ setDisplayURL:@"http://NEWURL.com"]; |
| 413 [controller_ ok:nil]; | 414 [controller_ ok:nil]; |
| 414 const BookmarkNode* new_node = group_bb_->GetChild(5); | 415 const BookmarkNode* new_node = group_bb_->GetChild(5); |
| 415 ASSERT_EQ(0, new_node->GetChildCount()); | 416 ASSERT_EQ(0, new_node->GetChildCount()); |
| 416 EXPECT_EQ(new_node->GetTitle(), L"NEW BOOKMARK"); | 417 EXPECT_EQ(new_node->GetTitle(), L"NEW BOOKMARK"); |
| 417 EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com")); | 418 EXPECT_EQ(new_node->GetURL(), GURL("http://NEWURL.com")); |
| 418 } | 419 } |
| OLD | NEW |