Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4249)

Unified Diff: chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Issue 3095004: [Mac] Use the new {EXPECT,ASSERT}_NS{EQ,NE} macros where possible. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Fix compile Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
diff --git a/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm b/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
index f437e71cfb50e4229d3a032d757932267a5e1c21..ba6490160fb78e260e489259e38f2a5d966baaee 100644
--- a/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
+++ b/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
@@ -13,6 +13,7 @@
#import "chrome/browser/cocoa/info_bubble_window.h"
#include "chrome/common/notification_service.h"
#include "testing/gtest/include/gtest/gtest.h"
+#import "testing/gtest_mac.h"
#include "testing/platform_test.h"
// Watch for bookmark pulse notifications so we can confirm they were sent.
@@ -318,11 +319,11 @@ TEST_F(BookmarkBubbleControllerTest, TestDuplicateNodeNames) {
[controller setParentFolderSelection:node1];
NSMenuItem* item = [button selectedItem];
id itemObject = [item representedObject];
- EXPECT_TRUE([itemObject isEqual:[NSValue valueWithPointer:node1]]);
+ EXPECT_NSEQ(itemObject, [NSValue valueWithPointer:node1]);
Mark Mentovai 2010/08/06 20:01:01 I think that this and the one on line 326 should b
[controller setParentFolderSelection:node2];
item = [button selectedItem];
itemObject = [item representedObject];
- EXPECT_TRUE([itemObject isEqual:[NSValue valueWithPointer:node2]]);
+ EXPECT_NSEQ(itemObject, [NSValue valueWithPointer:node2]);
}
// Click the "remove" button

Powered by Google App Engine
This is Rietveld 408576698