Save a little work when fetching the default title by only checking the name...

Neither name nor title are required for page- or browser-actions. Update loader
and unit tests.

BUG=25482
TEST=covered by unit tests

[Pam (message me for reviews), 2009-10-22 22:07:30]

I can't reproduce the problem described in the bug, and the unit tests appear to
cover that case correctly as well. But here's a little cleanup, while I was in
there.

[Aaron Boodman, 2009-10-22 22:44:01]

Neither the name nor default_title should be required for either page actions or
browser actions.

[Pam (message me for reviews), 2009-10-23 00:07:54]

Ah. New patch.

[Aaron Boodman, 2009-10-23 18:32:45]

One more nit

http://codereview.chromium.org/307048/diff/5001/5002
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/307048/diff/5001/5002#newcode345
Line 345: page_action->GetString(keys::kPageActionDefaultTitle, &title) ||
This code wasn't perfect before, but as long as you're in here:

We should report an error for optional properties if keys are present but the
wrong type.

so:

if (HasKey(first_try)) {
  if (!GetString(first_try))
    error
} else if (HasKey(second_try)) {
  if (!GetString(second_try))
    error
}

[Pam (message me for reviews), 2009-10-23 19:32:15]

Of course; sorry for not noticing that in the default_icon code. New patch.

- Pam

[Aaron Boodman, 2009-10-23 19:43:45]

lgtm

thanks!