Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: chrome/common/extensions/extension_constants.cc

Issue 307048: Save a little work when fetching the default title by only checking the name... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_constants.h" 5 #include "chrome/common/extensions/extension_constants.h"
6 6
7 namespace extension_manifest_keys { 7 namespace extension_manifest_keys {
8 8
9 const wchar_t* kBackground = L"background_page"; 9 const wchar_t* kBackground = L"background_page";
10 const wchar_t* kBrowserAction = L"browser_action"; 10 const wchar_t* kBrowserAction = L"browser_action";
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 "Invalid value for 'content_scripts[*].matches. There must be at least one " 91 "Invalid value for 'content_scripts[*].matches. There must be at least one "
92 "match specified."; 92 "match specified.";
93 const char* kInvalidMatch = 93 const char* kInvalidMatch =
94 "Invalid value for 'content_scripts[*].matches[*]'."; 94 "Invalid value for 'content_scripts[*].matches[*]'.";
95 const char* kInvalidMatches = 95 const char* kInvalidMatches =
96 "Required value 'content_scripts[*].matches' is missing or invalid."; 96 "Required value 'content_scripts[*].matches' is missing or invalid.";
97 const char* kInvalidName = 97 const char* kInvalidName =
98 "Required value 'name' is missing or invalid."; 98 "Required value 'name' is missing or invalid.";
99 const char* kInvalidPageAction = 99 const char* kInvalidPageAction =
100 "Invalid value for 'page_action'."; 100 "Invalid value for 'page_action'.";
101 const char* kInvalidPageActionName =
102 "Invalid value for 'page_action.name'.";
101 const char* kInvalidPageActionIconPath = 103 const char* kInvalidPageActionIconPath =
102 "Invalid value for 'page_action.default_icon'."; 104 "Invalid value for 'page_action.default_icon'.";
103 const char* kInvalidPageActionsList = 105 const char* kInvalidPageActionsList =
104 "Invalid value for 'page_actions'."; 106 "Invalid value for 'page_actions'.";
105 const char* kInvalidPageActionsListSize = 107 const char* kInvalidPageActionsListSize =
106 "Invalid value for 'page_actions'. There can be only one."; 108 "Invalid value for 'page_actions'. There can be only one.";
107 const char* kInvalidPageActionId = 109 const char* kInvalidPageActionId =
108 "Required value 'id' is missing or invalid."; 110 "Required value 'id' is missing or invalid.";
109 const char* kInvalidPageActionDefaultTitle = 111 const char* kInvalidPageActionDefaultTitle =
110 "Required value 'default_title' is missing or invalid."; 112 "Invalid value for 'default_title'.";
111 const char* kInvalidPageActionPopup = 113 const char* kInvalidPageActionPopup =
112 "Invalid type for page action popup."; 114 "Invalid type for page action popup.";
113 const char* kInvalidPageActionPopupHeight = 115 const char* kInvalidPageActionPopupHeight =
114 "Invalid value for page action popup height [*]."; 116 "Invalid value for page action popup height [*].";
115 const char* kInvalidPageActionPopupPath = 117 const char* kInvalidPageActionPopupPath =
116 "Invalid value for page action popup path [*]."; 118 "Invalid value for page action popup path [*].";
117 const char* kInvalidPageActionTypeValue = 119 const char* kInvalidPageActionTypeValue =
118 "Invalid value for 'page_actions[*].type', expected 'tab' or 'permanent'."; 120 "Invalid value for 'page_actions[*].type', expected 'tab' or 'permanent'.";
119 const char* kInvalidPermissions = 121 const char* kInvalidPermissions =
120 "Required value 'permissions' is missing or invalid."; 122 "Required value 'permissions' is missing or invalid.";
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 "An extension cannot have both a page action and a browser action."; 174 "An extension cannot have both a page action and a browser action.";
173 const char* kThemesCannotContainExtensions = 175 const char* kThemesCannotContainExtensions =
174 "A theme cannot contain extensions code."; 176 "A theme cannot contain extensions code.";
175 const char* kLocalesNoDefaultLocaleSpecified = 177 const char* kLocalesNoDefaultLocaleSpecified =
176 "Localization used, but default_locale wasn't specified in the manifest."; 178 "Localization used, but default_locale wasn't specified in the manifest.";
177 const char* kLocalesNoValidLocaleNamesListed = 179 const char* kLocalesNoValidLocaleNamesListed =
178 "No valid locale name could be found in _locales directory."; 180 "No valid locale name could be found in _locales directory.";
179 const char* kInvalidOptionsPage = 181 const char* kInvalidOptionsPage =
180 "Invalid value for 'options_page'."; 182 "Invalid value for 'options_page'.";
181 } // namespace extension_manifest_errors 183 } // namespace extension_manifest_errors
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698