chrome/common/extensions/extension_constants.cc - Issue 307048: Save a little work when fetching the default title by only checking the name...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 307048: Save a little work when fetching the default title by only checking the name... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/extension_constants.cc

===================================================================

--- chrome/common/extensions/extension_constants.cc (revision 29521)

+++ chrome/common/extensions/extension_constants.cc (working copy)

@@ -98,6 +98,8 @@

"Required value 'name' is missing or invalid.";

const char* kInvalidPageAction =

"Invalid value for 'page_action'.";

+const char* kInvalidPageActionName =

+ "Invalid value for 'page_action.name'.";

const char* kInvalidPageActionIconPath =

"Invalid value for 'page_action.default_icon'.";

const char* kInvalidPageActionsList =

@@ -107,7 +109,7 @@

const char* kInvalidPageActionId =

"Required value 'id' is missing or invalid.";

const char* kInvalidPageActionDefaultTitle =

- "Required value 'default_title' is missing or invalid.";

+ "Invalid value for 'default_title'.";

const char* kInvalidPageActionPopup =

"Invalid type for page action popup.";

const char* kInvalidPageActionPopupHeight =

« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »