Save a little work when fetching the default title by only checking the name...

chrome/common/extensions/extension.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "app/resource_bundle.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 322 matching lines @@
   if (page_action->HasKey(keys::kPageActionDefaultIcon)) {
     if (!page_action->GetString(keys::kPageActionDefaultIcon, &default_icon) ||
         default_icon.empty()) {
       *error = errors::kInvalidPageActionIconPath;
       return NULL;
     }
     // TODO(EXTENSIONS_DEPRECATED): one icon.
     result->AddIconPath(default_icon);
   }
 
-  // Read the page action |default_title|.
+  // Read the page action title from |default_title| if present, |name| if not
+  // (both optional).
   std::string title;
-  if (!page_action->GetString(keys::kName, &title) &&
-      !page_action->GetString(keys::kPageActionDefaultTitle, &title)) {
-    *error = errors::kInvalidPageActionDefaultTitle;
-    return NULL;
+  if (page_action->HasKey(keys::kPageActionDefaultTitle)) {
+    if (!page_action->GetString(keys::kPageActionDefaultTitle, &title)) {
+      *error = errors::kInvalidPageActionDefaultTitle;
+      return NULL;
+    }
+  } else if (page_action->HasKey(keys::kName)) {
+    if (!page_action->GetString(keys::kName, &title)) {
+      *error = errors::kInvalidPageActionName;
+      return NULL;
+    }
   }
   result->set_title(title);
 
   // Read the action's |popup| (optional).
   DictionaryValue* popup = NULL;
   std::string url_str;
   if (page_action->HasKey(keys::kPageActionPopup) &&
      !page_action->GetDictionary(keys::kPageActionPopup, &popup) &&
      !page_action->GetString(keys::kPageActionPopup, &url_str)) {
     *error = errors::kInvalidPageActionPopup;
@@ skipping 815 matching lines @@
     UserScript::PatternList::const_iterator pattern =
         content_script->url_patterns().begin();
     for (; pattern != content_script->url_patterns().end(); ++pattern) {
       if (pattern->match_subdomains() && pattern->host().empty())
         return true;
     }
   }
 
   return false;
 }