Issue 3058043: Clear render buffers

Issue 3058043: Clear render buffers (Closed)

Created:
10 years, 4 months ago by gman1

Modified:
9 years, 7 months ago

Reviewers:
greggman, apatrick, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Clear render buffers TEST=unit tests BUG=41300 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55169

Patch Set 3 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+629 lines, -17 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1	4 chunks	+16 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager.cc	View		2 chunks	+21 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager_unittest.cc	View	1 2	1 chunk	+103 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2	9 chunks	+181 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1	7 chunks	+9 lines, -9 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1	1 chunk	+275 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc	View		1 chunk	+16 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/renderbuffer_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/renderbuffer_manager_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick

http://codereview.chromium.org/3058043/diff/1/6 File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/3058043/diff/1/6#newcode837 gpu/command_buffer/service/gles2_cmd_decoder.cc:837: // Remembers the state of a some capabilites. typo ...

10 years, 4 months ago (2010-08-05 17:19:36 UTC) #2

greggman

10 years, 4 months ago (2010-08-05 20:01:41 UTC) #3

apatrick_chromium

10 years, 4 months ago (2010-08-05 20:06:12 UTC) #4

LGTM

http://codereview.chromium.org/3058043/diff/13001/14005
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/3058043/diff/13001/14005#newcode837
gpu/command_buffer/service/gles2_cmd_decoder.cc:837: // Remembers the state of a
some capabilities.
a some -> some

Expand Messages | Collapse Messages