Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

Issue 3058043: Clear render buffers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc
===================================================================
--- gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc (revision 54850)
+++ gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc (working copy)
@@ -72,16 +72,30 @@
template <>
void GLES2DecoderTestBase::SpecializedSetup<FramebufferRenderbuffer, 0>(
- bool /* valid */) {
+ bool valid) {
DoBindFramebuffer(GL_FRAMEBUFFER, client_framebuffer_id_,
kServiceFramebufferId);
+ if (valid) {
+ // Return GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT so the code
+ // doesn't try to clear the buffer. That is tested else where.
+ EXPECT_CALL(*gl_, CheckFramebufferStatusEXT(GL_FRAMEBUFFER))
+ .WillOnce(Return(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT))
+ .RetiresOnSaturation();
+ }
};
template <>
void GLES2DecoderTestBase::SpecializedSetup<FramebufferTexture2D, 0>(
- bool /* valid */) {
+ bool valid) {
DoBindFramebuffer(GL_FRAMEBUFFER, client_framebuffer_id_,
kServiceFramebufferId);
+ if (valid) {
+ // Return GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT so the code
+ // doesn't try to clear the buffer. That is tested else where.
+ EXPECT_CALL(*gl_, CheckFramebufferStatusEXT(GL_FRAMEBUFFER))
+ .WillOnce(Return(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT))
+ .RetiresOnSaturation();
+ }
};
template <>
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc ('k') | gpu/command_buffer/service/renderbuffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698