Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t)

Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t) (Closed)

Created:
11 years, 2 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate). We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29511

Patch Set 1 #

Patch Set 2 : More fixes. #

Patch Set 3 : More low-hanging fruit. #

Total comments: 1

Patch Set 4 : Print out PID as int64 in case ProcessId type ever grows. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	base/process_util.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/process_util_posix.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/app/chrome_dll_main.cc	View	3	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/memory_details.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/memory_details_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/process_watcher_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_thread.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

LG. Have you tried a quick `ack "int.*pid"` or similar? More obvious candidates?

11 years, 2 months ago (2009-10-19 23:30:18 UTC) #1

viettrungluu

On 2009/10/19 23:30:18, Nico wrote: > LG. > > Have you tried a quick `ack ...

11 years, 2 months ago (2009-10-19 23:44:38 UTC) #2

viettrungluu

I picked off some more low-hanging fruit, but there's still a lot left (at varying ...

11 years, 2 months ago (2009-10-20 02:19:58 UTC) #3

Nico

11 years, 2 months ago (2009-10-20 02:26:33 UTC) #5

/me curses at "reply" not attaching draft comments.

http://codereview.chromium.org/300010/diff/4001/5003
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/300010/diff/4001/5003#newcode460
Line 460: static_cast<int>(browser_pid));
Maybe use %ld (if StringPrintf() supports that) and a 64bit int, just in case?
:-P

Expand Messages | Collapse Messages