chrome/browser/memory_details_win.cc - Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory_details_win.cc

Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t) (Closed)

Patch Set: Print out PID as int64 in case ProcessId type ever grows. Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory_details_win.cc

diff --git a/chrome/browser/memory_details_win.cc b/chrome/browser/memory_details_win.cc

index 4c3d8bec680e120287811a4d40e0af7126979bee..56aa9fb276af75dd86b40f0183ad06e942b4b831 100644

--- a/chrome/browser/memory_details_win.cc

+++ b/chrome/browser/memory_details_win.cc

@@ -85,7 +85,7 @@ void MemoryDetails::CollectProcessData(

return;

}

do {

- int pid = process_entry.th32ProcessID;

+ base::ProcessId pid = process_entry.th32ProcessID;

ScopedHandle handle(::OpenProcess(

PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, FALSE, pid));

if (!handle.Get())

« no previous file with comments | « chrome/browser/memory_details.h ('k') | chrome/common/process_watcher_posix.cc » ('j') | no next file with comments »