Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/memory_details.h

Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t) (Closed)
Patch Set: Print out PID as int64 in case ProcessId type ever grows. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chrome_dll_main.cc ('k') | chrome/browser/memory_details_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEMORY_DETAILS_H_ 5 #ifndef CHROME_BROWSER_MEMORY_DETAILS_H_
6 #define CHROME_BROWSER_MEMORY_DETAILS_H_ 6 #define CHROME_BROWSER_MEMORY_DETAILS_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/process_util.h" 10 #include "base/process_util.h"
11 #include "base/ref_counted.h" 11 #include "base/ref_counted.h"
12 #include "chrome/common/child_process_info.h" 12 #include "chrome/common/child_process_info.h"
13 13
14 class MessageLoop; 14 class MessageLoop;
15 15
16 // We collect data about each browser process. A browser may 16 // We collect data about each browser process. A browser may
17 // have multiple processes (of course!). Even IE has multiple 17 // have multiple processes (of course!). Even IE has multiple
18 // processes these days. 18 // processes these days.
19 struct ProcessMemoryInformation { 19 struct ProcessMemoryInformation {
20 ProcessMemoryInformation() 20 ProcessMemoryInformation()
21 : pid(0), 21 : pid(0),
22 num_processes(0), 22 num_processes(0),
23 is_diagnostics(false), 23 is_diagnostics(false),
24 type(ChildProcessInfo::UNKNOWN_PROCESS) { 24 type(ChildProcessInfo::UNKNOWN_PROCESS) {
25 } 25 }
26 26
27 // The process id. 27 // The process id.
28 int pid; 28 base::ProcessId pid;
29 // The working set information. 29 // The working set information.
30 base::WorkingSetKBytes working_set; 30 base::WorkingSetKBytes working_set;
31 // The committed bytes. 31 // The committed bytes.
32 base::CommittedKBytes committed; 32 base::CommittedKBytes committed;
33 // The process version 33 // The process version
34 std::wstring version; 34 std::wstring version;
35 // The process product name. 35 // The process product name.
36 std::wstring product_name; 36 std::wstring product_name;
37 // The number of processes which this memory represents. 37 // The number of processes which this memory represents.
38 int num_processes; 38 int num_processes;
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // Returns a pointer to the ProcessData structure for Chrome. 116 // Returns a pointer to the ProcessData structure for Chrome.
117 ProcessData* ChromeBrowser(); 117 ProcessData* ChromeBrowser();
118 118
119 std::vector<ProcessData> process_data_; 119 std::vector<ProcessData> process_data_;
120 MessageLoop* ui_loop_; 120 MessageLoop* ui_loop_;
121 121
122 DISALLOW_EVIL_CONSTRUCTORS(MemoryDetails); 122 DISALLOW_EVIL_CONSTRUCTORS(MemoryDetails);
123 }; 123 };
124 124
125 #endif // CHROME_BROWSER_MEMORY_DETAILS_H_ 125 #endif // CHROME_BROWSER_MEMORY_DETAILS_H_
OLDNEW
« no previous file with comments | « chrome/app/chrome_dll_main.cc ('k') | chrome/browser/memory_details_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698