chrome/common/process_watcher_posix.cc - Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/process_watcher_posix.cc

Issue 300010: Cleanup: change PIDs to base::ProcessId (or pid_t) (Closed)

Patch Set: Print out PID as int64 in case ProcessId type ever grows. Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/process_watcher_posix.cc

diff --git a/chrome/common/process_watcher_posix.cc b/chrome/common/process_watcher_posix.cc

index 0991f0cb1e94ec6fc1681b6779c89eb8511544b5..8f0910190cf2cbb1cf14d6db0fb48e8cacfd11fb 100644

--- a/chrome/common/process_watcher_posix.cc

+++ b/chrome/common/process_watcher_posix.cc

@@ -15,7 +15,7 @@

// Return true if the given child is dead. This will also reap the process.

// Doesn't block.

static bool IsChildDead(pid_t child) {

- const int result = HANDLE_EINTR(waitpid(child, NULL, WNOHANG));

+ const pid_t result = HANDLE_EINTR(waitpid(child, NULL, WNOHANG));

if (result == -1) {

NOTREACHED();

} else if (result > 0) {

« no previous file with comments | « chrome/browser/memory_details_win.cc ('k') | chrome/renderer/render_thread.cc » ('j') | no next file with comments »