Issue 2872005: X64: Change some smi operations to work on untagged integers instead.

Issue 2872005: X64: Change some smi operations to work on untagged integers instead. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

X64: Change some smi operations to work on untagged integers instead. Use direct reading and writing of integers from Smi fields. Change RecordWrite with 0 offset to take untagged index instead of smi tagged index.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed review comments. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -92 lines)			Patch
M	src/x64/assembler-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	16 chunks	+71 lines, -78 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	10 chunks	+50 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/2872005/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2872005/diff/1/4#newcode4843 src/x64/codegen-x64.cc:4843: // r9 holds the index as int32. comments ...

10 years, 6 months ago (2010-06-17 10:57:34 UTC) #2

Lasse Reichstein

10 years, 6 months ago (2010-06-17 14:04:24 UTC) #3

http://codereview.chromium.org/2872005/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/2872005/diff/1/4#newcode4843
src/x64/codegen-x64.cc:4843: // r9 holds the index as int32.
Fixed.

http://codereview.chromium.org/2872005/diff/1/4#newcode8704
src/x64/codegen-x64.cc:8704: 
On 2010/06/17 10:57:34, Vyacheslav Egorov wrote:
> remove empty line?

Done.

http://codereview.chromium.org/2872005/diff/1/6
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/2872005/diff/1/6#newcode509
src/x64/macro-assembler-x64.cc:509: movl(Operand(dst, kSmiShift / kBitsPerByte),
src);
Done.
Maybe I should make kSmiShift/kBitsPerByte a constant.

Expand Messages | Collapse Messages