Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: src/x64/ic-x64.cc

Issue 2872005: X64: Change some smi operations to work on untagged integers instead. (Closed)
Patch Set: Addressed review comments. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 995 matching lines...) Expand 10 before | Expand all | Expand 10 after
1006 __ movq(FieldOperand(rbx, index.reg, index.scale, FixedArray::kHeaderSize), 1006 __ movq(FieldOperand(rbx, index.reg, index.scale, FixedArray::kHeaderSize),
1007 rax); 1007 rax);
1008 __ ret(0); 1008 __ ret(0);
1009 __ bind(&non_smi_value); 1009 __ bind(&non_smi_value);
1010 // Slow case that needs to retain rcx for use by RecordWrite. 1010 // Slow case that needs to retain rcx for use by RecordWrite.
1011 // Update write barrier for the elements array address. 1011 // Update write barrier for the elements array address.
1012 SmiIndex index2 = masm->SmiToIndex(kScratchRegister, rcx, kPointerSizeLog2); 1012 SmiIndex index2 = masm->SmiToIndex(kScratchRegister, rcx, kPointerSizeLog2);
1013 __ movq(FieldOperand(rbx, index2.reg, index2.scale, FixedArray::kHeaderSize), 1013 __ movq(FieldOperand(rbx, index2.reg, index2.scale, FixedArray::kHeaderSize),
1014 rax); 1014 rax);
1015 __ movq(rdx, rax); 1015 __ movq(rdx, rax);
1016 __ SmiToInteger32(rcx, rcx);
1016 __ RecordWriteNonSmi(rbx, 0, rdx, rcx); 1017 __ RecordWriteNonSmi(rbx, 0, rdx, rcx);
1017 __ ret(0); 1018 __ ret(0);
1018 } 1019 }
1019 1020
1020 1021
1021 void KeyedStoreIC::GenerateExternalArray(MacroAssembler* masm, 1022 void KeyedStoreIC::GenerateExternalArray(MacroAssembler* masm,
1022 ExternalArrayType array_type) { 1023 ExternalArrayType array_type) {
1023 // ----------- S t a t e ------------- 1024 // ----------- S t a t e -------------
1024 // -- rax : value 1025 // -- rax : value
1025 // -- rcx : key 1026 // -- rcx : key
(...skipping 826 matching lines...) Expand 10 before | Expand all | Expand 10 after
1852 GenerateMiss(masm); 1853 GenerateMiss(masm);
1853 } 1854 }
1854 1855
1855 1856
1856 #undef __ 1857 #undef __
1857 1858
1858 1859
1859 } } // namespace v8::internal 1860 } } // namespace v8::internal
1860 1861
1861 #endif // V8_TARGET_ARCH_X64 1862 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698