Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 2872005: X64: Change some smi operations to work on untagged integers instead. (Closed)
Patch Set: Addressed review comments. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1130 matching lines...) Expand 10 before | Expand all | Expand 10 after
1141 1141
1142 void Assembler::incl(const Operand& dst) { 1142 void Assembler::incl(const Operand& dst) {
1143 EnsureSpace ensure_space(this); 1143 EnsureSpace ensure_space(this);
1144 last_pc_ = pc_; 1144 last_pc_ = pc_;
1145 emit_optional_rex_32(dst); 1145 emit_optional_rex_32(dst);
1146 emit(0xFF); 1146 emit(0xFF);
1147 emit_operand(0, dst); 1147 emit_operand(0, dst);
1148 } 1148 }
1149 1149
1150 1150
1151 void Assembler::incl(Register dst) {
1152 EnsureSpace ensure_space(this);
1153 last_pc_ = pc_;
1154 emit_optional_rex_32(dst);
1155 emit(0xFF);
1156 emit_modrm(0, dst);
1157 }
1158
1159
1151 void Assembler::int3() { 1160 void Assembler::int3() {
1152 EnsureSpace ensure_space(this); 1161 EnsureSpace ensure_space(this);
1153 last_pc_ = pc_; 1162 last_pc_ = pc_;
1154 emit(0xCC); 1163 emit(0xCC);
1155 } 1164 }
1156 1165
1157 1166
1158 void Assembler::j(Condition cc, Label* L) { 1167 void Assembler::j(Condition cc, Label* L) {
1159 if (cc == always) { 1168 if (cc == always) {
1160 jmp(L); 1169 jmp(L);
(...skipping 1694 matching lines...) Expand 10 before | Expand all | Expand 10 after
2855 // specially coded on x64 means that it is a relative 32 bit address, as used 2864 // specially coded on x64 means that it is a relative 32 bit address, as used
2856 // by branch instructions. 2865 // by branch instructions.
2857 return (1 << rmode_) & kApplyMask; 2866 return (1 << rmode_) & kApplyMask;
2858 } 2867 }
2859 2868
2860 2869
2861 2870
2862 } } // namespace v8::internal 2871 } } // namespace v8::internal
2863 2872
2864 #endif // V8_TARGET_ARCH_X64 2873 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698