src/x64/ic-x64.cc - Issue 2872005: X64: Change some smi operations to work on untagged integers instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/ic-x64.cc

Issue 2872005: X64: Change some smi operations to work on untagged integers instead. (Closed)

Patch Set: Addressed review comments. Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/ic-x64.cc

diff --git a/src/x64/ic-x64.cc b/src/x64/ic-x64.cc

index f668f0c8f3a4881b031d5e8032561ace2fc99d63..83247355a7f51d233c413e5b6819daf7efdd140a 100644

--- a/src/x64/ic-x64.cc

+++ b/src/x64/ic-x64.cc

@@ -1013,6 +1013,7 @@ void KeyedStoreIC::GenerateGeneric(MacroAssembler* masm) {

__ movq(FieldOperand(rbx, index2.reg, index2.scale, FixedArray::kHeaderSize),

rax);

__ movq(rdx, rax);

+ __ SmiToInteger32(rcx, rcx);

__ RecordWriteNonSmi(rbx, 0, rdx, rcx);

__ ret(0);

}

« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »