Brushed up listen socket:

Brushed up listen socket:
- Upstreamed support for partial results from devtools' version
- Made DidRead receive data and length (in order to support websockets data)
- Fixed all the clients.
Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51635

[yurys, 2010-06-25 13:25:53]

lgtm

http://codereview.chromium.org/2868036/diff/1/5
File chrome/browser/debugger/devtools_remote_listen_socket.h (right):

http://codereview.chromium.org/2868036/diff/1/5#newcode27
chrome/browser/debugger/devtools_remote_listen_socket.h:27: //
ListenSocket::ListenSocketDelegate interface
I'd rather move it to the private section.

http://codereview.chromium.org/2868036/diff/1/7
File net/base/listen_socket.h (right):

http://codereview.chromium.org/2868036/diff/1/7#newcode54
net/base/listen_socket.h:54: virtual void DidRead(ListenSocket *connection,
const char* data, int len) = 0;
80 chars

http://codereview.chromium.org/2868036/diff/1/10
File net/base/telnet_server.cc (right):

http://codereview.chromium.org/2868036/diff/1/10#newcode200
net/base/telnet_server.cc:200: socket_delegate_->DidRead(this,
command_line_.c_str(), command_line_.length());
80 chars

http://codereview.chromium.org/2868036/diff/1/12
File net/server/http_listen_socket.cc (right):

http://codereview.chromium.org/2868036/diff/1/12#newcode1
net/server/http_listen_socket.cc:1: // Copyright (c) 2009 The Chromium Authors.
All rights reserved.
2009->2010

http://codereview.chromium.org/2868036/diff/1/12#newcode13
net/server/http_listen_socket.cc:13: // must run in the IO thread
Consider adding assert.

http://codereview.chromium.org/2868036/diff/1/12#newcode40
net/server/http_listen_socket.cc:40: HttpListenSocket::Delegate* delegate) {
80 chars

http://codereview.chromium.org/2868036/diff/1/12#newcode55
net/server/http_listen_socket.cc:55: HttpServerRequestInfo::HeadersMap::iterator
it = request->headers.find(header_name);
80 chars

http://codereview.chromium.org/2868036/diff/1/12#newcode193
net/server/http_listen_socket.cc:193: HttpServerRequestInfo*
HttpListenSocket::ParseHeaders() {
Could we have a test for this code?

http://codereview.chromium.org/2868036/diff/1/13
File net/server/http_listen_socket.h (right):

http://codereview.chromium.org/2868036/diff/1/13#newcode11
net/server/http_listen_socket.h:11: class HttpServerResponseInfo;
This seems to be unused.

http://codereview.chromium.org/2868036/diff/1/13#newcode41
net/server/http_listen_socket.h:41: void Listen() { ListenSocket::Listen(); }
Why is this needed?

http://codereview.chromium.org/2868036/diff/1/14
File net/server/http_server_request_info.h (right):

http://codereview.chromium.org/2868036/diff/1/14#newcode1
net/server/http_server_request_info.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2009 -> 2010

http://codereview.chromium.org/2868036/diff/1/15
File net/server/http_server_response_info.h (right):

http://codereview.chromium.org/2868036/diff/1/15#newcode1
net/server/http_server_response_info.h:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2009 -> 2010

http://codereview.chromium.org/2868036/diff/1/15#newcode5
net/server/http_server_response_info.h:5: #ifndef
NET_SERVER_HTTP_RESPONSE_INFO_H__
should be NET_SERVER_HTTP_    SERVER    _RESPONSE_INFO_H__