Chromium Code Reviews

Unified Diff: chrome/browser/debugger/devtools_remote_listen_socket.h

Issue 2868036: Brushed up listen socket: (Closed)
Patch Set: Lint. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « chrome/browser/debugger/devtools_remote.h ('k') | chrome/browser/debugger/devtools_remote_listen_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_remote_listen_socket.h
diff --git a/chrome/browser/debugger/devtools_remote_listen_socket.h b/chrome/browser/debugger/devtools_remote_listen_socket.h
index d53364fe27782198ee3a165288ca04406f695f6a..9424a767d727413a25e44e9425414487baf87664 100644
--- a/chrome/browser/debugger/devtools_remote_listen_socket.h
+++ b/chrome/browser/debugger/devtools_remote_listen_socket.h
@@ -14,26 +14,30 @@ class DevToolsRemoteListener;
// Listens to remote debugger incoming connections, handles the V8ARDP protocol
// socket input and invokes the message handler when appropriate.
-class DevToolsRemoteListenSocket : public ListenSocket {
+class DevToolsRemoteListenSocket : public ListenSocket,
+ public ListenSocket::ListenSocketDelegate {
public:
// Listen on port for the specified IP address. Use 127.0.0.1 to only
// accept local connections.
static DevToolsRemoteListenSocket* Listen(
const std::string& ip,
int port,
- ListenSocketDelegate* del,
DevToolsRemoteListener* message_listener);
protected:
virtual void Listen() { ListenSocket::Listen(); }
virtual void Accept();
- virtual void Read();
virtual void Close();
virtual void SendInternal(const char* bytes, int len);
private:
virtual ~DevToolsRemoteListenSocket();
+ // ListenSocket::ListenSocketDelegate interface
+ virtual void DidAccept(ListenSocket *server, ListenSocket *connection);
+ virtual void DidRead(ListenSocket *connection, const char* data, int len);
+ virtual void DidClose(ListenSocket *connection);
+
// The protocol states while reading socket input
enum State {
INVALID = 0, // Bad handshake message received, retry
@@ -43,11 +47,9 @@ class DevToolsRemoteListenSocket : public ListenSocket {
};
DevToolsRemoteListenSocket(SOCKET s,
- ListenSocketDelegate *del,
DevToolsRemoteListener *listener);
void StartNextField();
void HandleMessage();
- void DispatchRead(char* buf, int len);
void DispatchField();
const std::string& GetHeader(const std::string& header_name,
const std::string& default_value) const;
« no previous file with comments | « chrome/browser/debugger/devtools_remote.h ('k') | chrome/browser/debugger/devtools_remote_listen_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine