Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Unified Diff: chrome/browser/debugger/devtools_remote_listen_socket_unittest.h

Issue 2868036: Brushed up listen socket: (Closed)
Patch Set: Lint. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
diff --git a/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h b/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
index 91db5372452bb26b7d7230c02e12f60a91fb50fb..b4987b840ae0cb0d63cf38160fa8d780ca02ce84 100644
--- a/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
+++ b/chrome/browser/debugger/devtools_remote_listen_socket_unittest.h
@@ -78,7 +78,6 @@ class ListenSocketTestAction {
// This had to be split out into a separate class because I couldn't
// make a the testing::Test class refcounted.
class DevToolsRemoteListenSocketTester :
- public ListenSocket::ListenSocketDelegate,
public DevToolsRemoteListener {
public:
DevToolsRemoteListenSocketTester()
@@ -99,7 +98,8 @@ class DevToolsRemoteListenSocketTester :
// DevToolsRemoteMessageHandler interface
virtual void HandleMessage(const DevToolsRemoteMessage& message);
- virtual void OnConnectionLost() {}
+ virtual void OnAcceptConnection(ListenSocket* connection);
+ virtual void OnConnectionLost();
// read all pending data from the test socket
int ClearTestSocket();
@@ -107,9 +107,6 @@ class DevToolsRemoteListenSocketTester :
void Shutdown();
void Listen();
void SendFromTester();
- virtual void DidAccept(ListenSocket *server, ListenSocket *connection);
- virtual void DidRead(ListenSocket *connection, const std::string& data);
- virtual void DidClose(ListenSocket *sock);
virtual bool Send(SOCKET sock, const std::string& str);
// verify the send/read from client to server
void TestClientSend();

Powered by Google App Engine
This is Rietveld 408576698