Clang/mac: Get unit_tests built.

Clang/mac: Get unit_tests built.

Not for review.

(closing, this has been committed in pieces and is no longer needed)

[Evan Martin, 2010-06-23 00:36:01]

didn't finish reviewing, some early commetns

http://codereview.chromium.org/2857015/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2857015/diff/1/2#newcode1177
build/common.gypi:1177: '-Wno-bool-conversions',
Are we sure this is ok for gcc too?

http://codereview.chromium.org/2857015/diff/1/5
File chrome/browser/autofill/form_structure_unittest.cc (right):

http://codereview.chromium.org/2857015/diff/1/5#newcode38
chrome/browser/autofill/form_structure_unittest.cc:38: }
newline above +  // namespace webkit_glue

http://codereview.chromium.org/2857015/diff/1/9
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/2857015/diff/1/9#newcode792
chrome/browser/cocoa/bookmark_bar_controller.mm:792: NSMenuItem* item =
(NSMenuItem*)anItem;  // FIXME: clang wants this.
I think you should fix clang rather than workaround this.

http://codereview.chromium.org/2857015/diff/1/21
File chrome/browser/importer/firefox_importer_unittest.cc (right):

http://codereview.chromium.org/2857015/diff/1/21#newcode18
chrome/browser/importer/firefox_importer_unittest.cc:18: #if 0
shouldn't do this either

[Nico, 2010-06-23 00:37:04]

Oh sorry, this one is not for review, it has #if 0 etc.
http://codereview.chromium.org/2876002/show contains the reviewable parts.