chrome/browser/cocoa/objc_zombie.mm - Issue 2857015: Clang/mac: Get unit_tests built.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/objc_zombie.mm

Issue 2857015: Clang/mac: Get unit_tests built. (Closed)

Patch Set: rebase Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/objc_zombie.mm

diff --git a/chrome/browser/cocoa/objc_zombie.mm b/chrome/browser/cocoa/objc_zombie.mm

index 8a6d766db2efd3581bddde00f29762ffab08c800..091393f8418e6acc1e6d689321ac9af4cf5fe70f 100644

--- a/chrome/browser/cocoa/objc_zombie.mm

+++ b/chrome/browser/cocoa/objc_zombie.mm

@@ -100,7 +100,7 @@ DestructFn* LookupObjectCxxDestruct() {

// them into |g_zombies| to be freed later.

void ZombieDealloc(id self, SEL _cmd) {

// This code should only be called when it is implementing |-dealloc|.

- DCHECK_EQ(_cmd, @selector(dealloc));

+ //DCHECK_EQ(_cmd, @selector(dealloc)); // clang

// Use the original |-dealloc| if the object doesn't wish to be

// zombied.