Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: webcore.patch

Issue 2857015: Clang/mac: Get unit_tests built. (Closed)
Patch Set: rebase Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « testing/gmock/include/gmock/gmock-actions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 Index: storage/StorageNamespaceImpl.cpp
2 ===================================================================
3 --- storage/StorageNamespaceImpl.cpp (revision 60900)
4 +++ storage/StorageNamespaceImpl.cpp (working copy)
5 @@ -108,7 +108,7 @@
6
7 RefPtr<SecurityOrigin> origin = prpOrigin;
8 RefPtr<StorageAreaImpl> storageArea;
9 - if (storageArea = m_storageAreaMap.get(origin))
10 + if ((storageArea = m_storageAreaMap.get(origin)))
11 return storageArea.release();
12
13 storageArea = StorageAreaImpl::create(m_storageType, origin, m_syncManager, m_quota);
14 Index: page/animation/AnimationBase.h
15 ===================================================================
16 --- page/animation/AnimationBase.h (revision 60900)
17 +++ page/animation/AnimationBase.h (working copy)
18 @@ -42,7 +42,7 @@
19 class Node;
20 class RenderObject;
21 class RenderStyle;
22 -class TimingFunction;
23 +struct TimingFunction;
24
25 class AnimationBase : public RefCounted<AnimationBase> {
26 friend class CompositeAnimation;
27 Index: platform/graphics/mac/FontPlatformData.h
28 ===================================================================
29 --- platform/graphics/mac/FontPlatformData.h (revision 60900)
30 +++ platform/graphics/mac/FontPlatformData.h (working copy)
31 @@ -51,7 +51,8 @@
32 inline CTFontRef toCTFontRef(NSFont *nsFont) { return reinterpret_cast<CTFontRe f>(nsFont); }
33 #endif
34
35 -struct FontPlatformData {
36 +class FontPlatformData { // FIXME
37 + public:
38 FontPlatformData(float size, bool syntheticBold, bool syntheticOblique)
39 : m_syntheticBold(syntheticBold)
40 , m_syntheticOblique(syntheticOblique)
41 Index: platform/graphics/BitmapImage.h
42 ===================================================================
43 --- platform/graphics/BitmapImage.h (revision 60900)
44 +++ platform/graphics/BitmapImage.h (working copy)
45 @@ -57,7 +57,7 @@
46 // invoking our constructor or destructor. This allows us to have a vector even for a struct
47 // that's not copyable.
48 namespace WTF {
49 - template<> class VectorTraits<WebCore::FrameData> : public SimpleClassVecto rTraits {};
50 + template<> struct VectorTraits<WebCore::FrameData> : public SimpleClassVect orTraits {};
51 }
52
53 namespace WebCore {
54 Index: accessibility/AccessibilityTableCell.cpp
55 ===================================================================
56 --- accessibility/AccessibilityTableCell.cpp (revision 60900)
57 +++ accessibility/AccessibilityTableCell.cpp (working copy)
58 @@ -71,7 +71,7 @@
59 AccessibilityObject* AccessibilityTableCell::parentTable() const
60 {
61 if (!m_renderer || !m_renderer->isTableCell())
62 - return false;
63 + return NULL;
64
65 return axObjectCache()->getOrCreate(toRenderTableCell(m_renderer)->table()) ;
66 }
67 Index: accessibility/AccessibilityRenderObject.cpp
68 ===================================================================
69 --- accessibility/AccessibilityRenderObject.cpp (revision 60900)
70 +++ accessibility/AccessibilityRenderObject.cpp (working copy)
71 @@ -1255,11 +1255,11 @@
72 HTMLLabelElement* AccessibilityRenderObject::labelElementContainer() const
73 {
74 if (!m_renderer)
75 - return false;
76 + return NULL;
77
78 // the control element should not be considered part of the label
79 if (isControl())
80 - return false;
81 + return NULL;
82
83 // find if this has a parent that is a label
84 for (Node* parentNode = m_renderer->node(); parentNode; parentNode = parent Node->parentNode()) {
85 Index: bindings/v8/NPV8Object.cpp
86 ===================================================================
87 --- bindings/v8/NPV8Object.cpp (revision 60900)
88 +++ bindings/v8/NPV8Object.cpp (working copy)
89 @@ -58,7 +58,7 @@
90
91 WrapperTypeInfo* npObjectTypeInfo()
92 {
93 - static WrapperTypeInfo typeInfo = { 0, 0, false };
94 + static WrapperTypeInfo typeInfo = { 0, 0, NULL };
95 return &typeInfo;
96 }
97
98 Index: bindings/v8/custom/V8HTMLOptionElementConstructor.cpp
99 ===================================================================
100 --- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp (revision 60900)
101 +++ bindings/v8/custom/V8HTMLOptionElementConstructor.cpp (working copy)
102 @@ -44,7 +44,7 @@
103
104 namespace WebCore {
105
106 -WrapperTypeInfo V8HTMLOptionElementConstructor::info = { V8HTMLOptionElementCon structor::GetTemplate, 0, false };
107 +WrapperTypeInfo V8HTMLOptionElementConstructor::info = { V8HTMLOptionElementCon structor::GetTemplate, 0, NULL };
108
109 static v8::Handle<v8::Value> v8HTMLOptionElementConstructorCallback(const v8::A rguments& args)
110 {
111 Index: html/HTMLFormElement.cpp
112 ===================================================================
113 --- html/HTMLFormElement.cpp (revision 60900)
114 +++ html/HTMLFormElement.cpp (working copy)
115 @@ -648,7 +648,7 @@
116
117 // see if we have seen something with this name before
118 RefPtr<HTMLFormControlElement> aliasElem;
119 - if (aliasElem = elementForAlias(name)) {
120 + if ((aliasElem = elementForAlias(name))) {
121 bool found = false;
122 for (unsigned n = 0; n < namedItems.size(); n++) {
123 if (namedItems[n] == aliasElem.get()) {
124 Index: inspector/InspectorValues.cpp
125 ===================================================================
126 --- inspector/InspectorValues.cpp (revision 60900)
127 +++ inspector/InspectorValues.cpp (working copy)
128 @@ -599,7 +599,7 @@
129 {
130 PassRefPtr<InspectorValue> value = get(name);
131 if (!value)
132 - return false;
133 + return 0;
134 return value->asObject();
135 }
136
137 @@ -607,7 +607,7 @@
138 {
139 PassRefPtr<InspectorValue> value = get(name);
140 if (!value)
141 - return false;
142 + return 0;
143 return value->asArray();
144 }
145
146 Index: rendering/RootInlineBox.cpp
147 ===================================================================
148 --- rendering/RootInlineBox.cpp (revision 60900)
149 +++ rendering/RootInlineBox.cpp (working copy)
150 @@ -411,7 +411,7 @@
151 EllipsisBox* RootInlineBox::ellipsisBox() const
152 {
153 if (!m_hasEllipsisBox)
154 - return false;
155 + return NULL;
156 return gEllipsisBoxMap->get(this);
157 }
158
159 Index: rendering/RenderBlock.h
160 ===================================================================
161 --- rendering/RenderBlock.h (revision 60900)
162 +++ rendering/RenderBlock.h (working copy)
163 @@ -38,7 +38,7 @@
164 struct BidiRun;
165
166 template <class Iterator, class Run> class BidiResolver;
167 -template <class Iterator> class MidpointState;
168 +template <class Iterator> struct MidpointState;
169 typedef BidiResolver<InlineIterator, BidiRun> InlineBidiResolver;
170 typedef MidpointState<InlineIterator> LineMidpointState;
171
172 Index: css/CSSStyleSheet.h
173 ===================================================================
174 --- css/CSSStyleSheet.h (revision 60900)
175 +++ css/CSSStyleSheet.h (working copy)
176 @@ -26,7 +26,7 @@
177
178 namespace WebCore {
179
180 -class CSSNamespace;
181 +struct CSSNamespace;
182 class CSSParser;
183 class CSSRule;
184 class DocLoader;
OLDNEW
« no previous file with comments | « testing/gmock/include/gmock/gmock-actions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698