Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: build/common.gypi

Issue 2857015: Clang/mac: Get unit_tests built. (Closed)
Patch Set: rebase Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging.h ('k') | chrome/browser/autocomplete/autocomplete_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index bf11869d3ef76d5c66156ec5bd65c8f0ce40ad22..b920a5e1a7f280cfd9fc5855bc80dbf594eec531 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1193,6 +1193,8 @@
'-Wextra',
'-Wno-sign-compare', # clang warns a lot without this
# (todo: track down and fix everything)
+ # gtest confuses clang.
+ '-Wno-bool-conversions',
# Don't warn about unused function parameters.
'-Wno-unused-parameter',
# Don't warn about the "struct foo f = {0};" initialization
« no previous file with comments | « base/logging.h ('k') | chrome/browser/autocomplete/autocomplete_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698