Use string for Histogram names since these are all ASCII anyway wide-characte...

Use string for Histogram names since these are all ASCII anyway.
Wide-character literals cause problems between platforms.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10276

[dsh, 2009-02-24 00:31:11]

I don't know who should review this.  Feel free to pass it along if you don't
know why Histograms were made to take wide strings as names.

Thanks!

[brettw, 2009-02-24 00:59:13]

You should use const char* instead of std::string. A typical call is like this: 
  UMA_HISTOGRAM_COUNTS(L"SB2.BuildWriteBytes", ...);

Your patch will turn each of these calls into a heap allocation inside
std::string, which is bad considering how often these are called.

[jar (doing other things), 2009-02-24 17:27:21]

The use of wide strings was (historically) done to mate with  the base class
Stats.  Mbelshe confirmed that this is no longer an issue, and so conceptually
this is a fine change.

I was initially worried about UMA, which MD5 hashes the names and uses them to
upload, but we're already using char* in the underlying Histogram classes, so
this is not a problem.

Nit and typo below.

Thanks!

http://codereview.chromium.org/28046/diff/1191/1216
File base/message_loop.cc (right):

http://codereview.chromium.org/28046/diff/1191/1216#newcode508
Line 508: ("MsgLoop:" + thread_name_).c_str(),
nit: correct indentation

http://codereview.chromium.org/28046/diff/1191/1199
File chrome/browser/browser_shutdown.cc (right):

http://codereview.chromium.org/28046/diff/1191/1199#newcode194
Line 194: const char *time_per_fmt = "Shutdown.%ls.time_per_process";
Both format strings should be changed from "%ls" to "%s"

[dsh, 2009-02-24 18:38:02]

Thanks!  Fixed.  Actually, I think the indentation was a little weird before,
but I've made this nicer.

[jar (doing other things), 2009-02-24 19:08:54]

LGTM

Caveat landor:

(Sorry if this is obvious...)

Be sure to sync just before you land, and then try to build, or you'll likely
break the tree, as this touches a lot of code. I'd suggest landing this late at
night when the tree is "moving very slowly."