Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database_bloom.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database_bloom.cc
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_database_bloom.cc (revision 10269)
+++ chrome/browser/safe_browsing/safe_browsing_database_bloom.cc (working copy)
@@ -91,7 +91,7 @@
if (!file_util::GetFileSize(bloom_filter_filename_, &size_64) ||
size_64 == 0) {
- UMA_HISTOGRAM_COUNTS(L"SB2.FilterMissing", 1);
+ UMA_HISTOGRAM_COUNTS("SB2.FilterMissing", 1);
return;
}
@@ -403,7 +403,7 @@
chunks->pop_front();
}
- UMA_HISTOGRAM_TIMES(L"SB2.ChunkInsert", base::Time::Now() - insert_start);
+ UMA_HISTOGRAM_TIMES("SB2.ChunkInsert", base::Time::Now() - insert_start);
delete chunks;
@@ -1316,7 +1316,7 @@
int rv = insert_transaction_->Commit();
if (rv != SQLITE_OK) {
NOTREACHED() << "SafeBrowsing update transaction failed to commit.";
- UMA_HISTOGRAM_COUNTS(L"SB2.FailedUpdate", 1);
+ UMA_HISTOGRAM_COUNTS("SB2.FailedUpdate", 1);
return;
}
@@ -1337,28 +1337,28 @@
// Gather statistics.
#if defined(OS_WIN)
metric->GetIOCounters(&io_after);
- UMA_HISTOGRAM_COUNTS(L"SB2.BuildReadBytes",
+ UMA_HISTOGRAM_COUNTS("SB2.BuildReadBytes",
static_cast<int>(io_after.ReadTransferCount -
io_before.ReadTransferCount));
- UMA_HISTOGRAM_COUNTS(L"SB2.BuildWriteBytes",
+ UMA_HISTOGRAM_COUNTS("SB2.BuildWriteBytes",
static_cast<int>(io_after.WriteTransferCount -
io_before.WriteTransferCount));
- UMA_HISTOGRAM_COUNTS(L"SB2.BuildReadOperations",
+ UMA_HISTOGRAM_COUNTS("SB2.BuildReadOperations",
static_cast<int>(io_after.ReadOperationCount -
io_before.ReadOperationCount));
- UMA_HISTOGRAM_COUNTS(L"SB2.BuildWriteOperations",
+ UMA_HISTOGRAM_COUNTS("SB2.BuildWriteOperations",
static_cast<int>(io_after.WriteOperationCount -
io_before.WriteOperationCount));
#endif
SB_DLOG(INFO) << "SafeBrowsingDatabaseImpl built bloom filter in "
<< bloom_gen.InMilliseconds()
<< " ms total. prefix count: "<< add_count_;
- UMA_HISTOGRAM_LONG_TIMES(L"SB2.BuildFilter", bloom_gen);
- UMA_HISTOGRAM_COUNTS(L"SB2.AddPrefixes", add_count_);
- UMA_HISTOGRAM_COUNTS(L"SB2.SubPrefixes", subs);
+ UMA_HISTOGRAM_LONG_TIMES("SB2.BuildFilter", bloom_gen);
+ UMA_HISTOGRAM_COUNTS("SB2.AddPrefixes", add_count_);
+ UMA_HISTOGRAM_COUNTS("SB2.SubPrefixes", subs);
int64 size_64;
if (file_util::GetFileSize(filename_, &size_64))
- UMA_HISTOGRAM_COUNTS(L"SB2.DatabaseBytes", static_cast<int>(size_64));
+ UMA_HISTOGRAM_COUNTS("SB2.DatabaseBytes", static_cast<int>(size_64));
}
void SafeBrowsingDatabaseBloom::GetCachedFullHashes(
« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698