Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: net/disk_cache/backend_impl.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/x509_certificate.cc ('k') | net/disk_cache/block_files.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_impl.cc
===================================================================
--- net/disk_cache/backend_impl.cc (revision 10269)
+++ net/disk_cache/backend_impl.cc (working copy)
@@ -276,7 +276,7 @@
DCHECK(entry);
*entry = cache_entry;
- UMA_HISTOGRAM_TIMES(L"DiskCache.OpenTime", Time::Now() - start);
+ UMA_HISTOGRAM_TIMES("DiskCache.OpenTime", Time::Now() - start);
stats_.OnEvent(Stats::OPEN_HIT);
return true;
}
@@ -349,7 +349,7 @@
*entry = NULL;
cache_entry.swap(reinterpret_cast<EntryImpl**>(entry));
- UMA_HISTOGRAM_TIMES(L"DiskCache.CreateTime", Time::Now() - start);
+ UMA_HISTOGRAM_TIMES("DiskCache.CreateTime", Time::Now() - start);
stats_.OnEvent(Stats::CREATE_HIT);
Trace("create entry hit ");
return true;
@@ -651,7 +651,7 @@
}
void BackendImpl::ReportError(int error) {
- static LinearHistogram counter(L"DiskCache.Error", 0, 49, 50);
+ static LinearHistogram counter("DiskCache.Error", 0, 49, 50);
counter.SetFlags(kUmaTargetedHistogramFlag);
// We transmit positive numbers, instead of direct error codes.
@@ -679,9 +679,9 @@
if (first_time) {
first_time = false;
int experiment = data_->header.experiment;
- std::wstring entries(StringPrintf(L"DiskCache.Entries_%d", experiment));
- std::wstring size(StringPrintf(L"DiskCache.Size_%d", experiment));
- std::wstring max_size(StringPrintf(L"DiskCache.MaxSize_%d", experiment));
+ std::string entries(StringPrintf("DiskCache.Entries_%d", experiment));
+ std::string size(StringPrintf("DiskCache.Size_%d", experiment));
+ std::string max_size(StringPrintf("DiskCache.MaxSize_%d", experiment));
UMA_HISTOGRAM_COUNTS(entries.c_str(), data_->header.num_entries);
UMA_HISTOGRAM_COUNTS(size.c_str(), data_->header.num_bytes / (1024 * 1024));
UMA_HISTOGRAM_COUNTS(max_size.c_str(), max_size_ / (1024 * 1024));
« no previous file with comments | « net/base/x509_certificate.cc ('k') | net/disk_cache/block_files.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698