Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Unified Diff: chrome/browser/net/dns_host_info.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/net/dns_master.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/dns_host_info.cc
===================================================================
--- chrome/browser/net/dns_host_info.cc (revision 10269)
+++ chrome/browser/net/dns_host_info.cc (working copy)
@@ -89,7 +89,7 @@
state_ = ASSIGNED;
queue_duration_ = GetDuration();
DLogResultsStats("DNS Prefetch assigned");
- UMA_HISTOGRAM_TIMES(L"DNS.PrefetchQueue", queue_duration_);
+ UMA_HISTOGRAM_TIMES("DNS.PrefetchQueue", queue_duration_);
}
void DnsHostInfo::SetPendingDeleteState() {
@@ -102,7 +102,7 @@
state_ = FOUND;
resolve_duration_ = GetDuration();
if (kMaxNonNetworkDnsLookupDuration <= resolve_duration_) {
- UMA_HISTOGRAM_LONG_TIMES(L"DNS.PrefetchFoundNameL", resolve_duration_);
+ UMA_HISTOGRAM_LONG_TIMES("DNS.PrefetchFoundNameL", resolve_duration_);
// Record potential beneficial time, and maybe we'll get a cache hit.
// We keep the maximum, as the warming we did earlier may still be
// helping with a cache upstream in DNS resolution.
@@ -117,7 +117,7 @@
state_ = NO_SUCH_NAME;
resolve_duration_ = GetDuration();
if (kMaxNonNetworkDnsLookupDuration <= resolve_duration_) {
- DHISTOGRAM_TIMES(L"DNS.PrefetchNotFoundName", resolve_duration_);
+ DHISTOGRAM_TIMES("DNS.PrefetchNotFoundName", resolve_duration_);
// Record potential beneficial time, and maybe we'll get a cache hit.
benefits_remaining_ = std::max(resolve_duration_, benefits_remaining_);
}
@@ -176,10 +176,10 @@
if ((0 == benefits_remaining_.InMilliseconds()) ||
(FOUND != state_ && NO_SUCH_NAME != state_)) {
if (FINISHED == navigation_info->state_)
- UMA_HISTOGRAM_LONG_TIMES(L"DNS.IndependentNavigation",
+ UMA_HISTOGRAM_LONG_TIMES("DNS.IndependentNavigation",
navigation_info->resolve_duration_);
else
- UMA_HISTOGRAM_LONG_TIMES(L"DNS.IndependentFailedNavigation",
+ UMA_HISTOGRAM_LONG_TIMES("DNS.IndependentFailedNavigation",
navigation_info->resolve_duration_);
return PREFETCH_NO_BENEFIT;
}
@@ -195,13 +195,13 @@
if (navigation_info->resolve_duration_ > kMaxNonNetworkDnsLookupDuration) {
// Our precache effort didn't help since HTTP stack hit the network.
- UMA_HISTOGRAM_LONG_TIMES(L"DNS.PrefetchCacheEvictionL", resolve_duration_);
+ UMA_HISTOGRAM_LONG_TIMES("DNS.PrefetchCacheEvictionL", resolve_duration_);
DLogResultsStats("DNS PrefetchCacheEviction");
return PREFETCH_CACHE_EVICTION;
}
if (NO_SUCH_NAME == state_) {
- UMA_HISTOGRAM_LONG_TIMES(L"DNS.PrefetchNegativeHitL", benefit);
+ UMA_HISTOGRAM_LONG_TIMES("DNS.PrefetchNegativeHitL", benefit);
DLogResultsStats("DNS PrefetchNegativeHit");
return PREFETCH_NAME_NONEXISTANT;
}
@@ -209,10 +209,10 @@
DCHECK_EQ(FOUND, state_);
if (LEARNED_REFERAL_MOTIVATED == motivation_ ||
STATIC_REFERAL_MOTIVATED == motivation_) {
- UMA_HISTOGRAM_TIMES(L"DNS.PrefetchReferredPositiveHit", benefit);
+ UMA_HISTOGRAM_TIMES("DNS.PrefetchReferredPositiveHit", benefit);
DLogResultsStats("DNS PrefetchReferredPositiveHit");
} else {
- UMA_HISTOGRAM_LONG_TIMES(L"DNS.PrefetchPositiveHitL", benefit);
+ UMA_HISTOGRAM_LONG_TIMES("DNS.PrefetchPositiveHitL", benefit);
DLogResultsStats("DNS PrefetchPositiveHit");
}
return PREFETCH_NAME_FOUND;
@@ -408,4 +408,3 @@
}
} // namespace chrome_browser_net
-
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/net/dns_master.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698