Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 27238: Clean up some style and organization in the browser about handler. No code... (Closed)

Created:
11 years, 10 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Clean up the browser about URL handler to not derive from WebContents. It is instead integrated in the BrowserURLHandler for special schemes. This solves a number of problems and cleans things up nicely. Most of the functions were not necessary to have in the header file of the browser about handler, so I made them local to the .cc file. I moved everything around, but there was no change to any of the About...() functions. This improves the about:memory page to not include the memory of the new tab page it replaced. The entry for itself also has the proper title. This works by using a meta refresh to the actual page, the the process transition no longer happens at the same time as the about:memory page computation. This also fixes problems with the about:network and about:ipc dialogs opening blank pages and also re-opening the dialog when you close the browser. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10941

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -352 lines) Patch
M chrome/browser/browser_about_handler.h View 2 3 1 chunk +11 lines, -66 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 8 chunks +273 lines, -260 lines 0 comments Download
M chrome/browser/browser_url_handler.cc View 2 3 3 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 3 3 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 2 3 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_factory.cc View 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_type.h View 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.cc View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
11 years, 9 months ago (2009-03-03 06:18:52 UTC) #1
Mike Belshe
11 years, 9 months ago (2009-03-03 15:55:04 UTC) #2
Mike Belshe
11 years, 9 months ago (2009-03-03 16:55:50 UTC) #3
looks good, with comments below

http://codereview.chromium.org/27238/diff/2018/3017
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/27238/diff/2018/3017#newcode601
Line 601: if (AboutHandler::WillHandle(*url))
I wonder if this should be renamed "RendererAboutHandler"?

http://codereview.chromium.org/27238/diff/2018/3027
File chrome/browser/memory_details.cc (right):

http://codereview.chromium.org/27238/diff/2018/3027#newcode233
Line 233: contents->controller()->GetPendingEntry();
whoops - this is broken (set to null rather than GetPendingEntry()).

But - given the redirect, should we get rid of the PendingEntry checking and
associated comment above?

Powered by Google App Engine
This is Rietveld 408576698