Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4924)

Unified Diff: chrome/browser/browser_about_handler.h

Issue 27238: Clean up some style and organization in the browser about handler. No code... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.h
===================================================================
--- chrome/browser/browser_about_handler.h (revision 10892)
+++ chrome/browser/browser_about_handler.h (working copy)
@@ -7,76 +7,21 @@
#ifndef CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
#define CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
-#include <string>
-
-#include "base/basictypes.h"
#include "chrome/browser/tab_contents/tab_contents_type.h"
-#include "chrome/browser/tab_contents/web_contents.h"
-#include "chrome/browser/dom_ui/chrome_url_data_manager.h"
-class AboutSource;
-class DictionaryValue;
class GURL;
-class ListValue;
-class Profile;
-class RenderProcessHost;
-class RenderViewHostFactory;
-class SiteInstance;
-class BrowserAboutHandler : public WebContents {
- public:
- BrowserAboutHandler(Profile* profile,
- SiteInstance* instance,
- RenderViewHostFactory* render_view_factory);
- virtual ~BrowserAboutHandler() {}
+// Decides whether the given URL will be handled by the browser about handler
+// and returns true if so. On true, it may also modify the given URL to be the
+// final form (we fix up most "about:" URLs to be "chrome-ui:" because WebKit
+// handles all "about:" URLs as "about:blank.
+//
+// This is used by BrowserURLHandler.
+bool WillHandleBrowserAboutURL(GURL* url, TabContentsType* type);
- // We don't want a favicon on the about pages.
- virtual bool ShouldDisplayFavIcon() { return false; }
- // Enable javascript urls for the about pages.
- virtual bool SupportsURL(GURL* url);
+// We have a few magic commands that don't cause navigations, but rather pop up
+// dialogs. This function handles those cases, and returns true if so. In this
+// case, normal tab navigation should be skipped.
+bool HandleNonNavigationAboutURL(const GURL& url);
- // If |url| is a known "about:" URL, this method handles it
- // and sets |url| to an alternate URL indicating the real content to load.
- // (If it's not a URL that the function can handle, it's a no-op and returns
- // false.)
- static bool MaybeHandle(GURL* url, TabContentsType* type);
-
- // Renders a special page for "about:" which displays version information.
- static std::string AboutVersion();
-
- // Renders a special page for about:plugins.
- static std::string AboutPlugins();
-
- // Renders a special page for about:histograms.
- static std::string AboutHistograms(const std::string& query);
-
- // Renders a special page about:objects (about tracked objects such as Tasks).
- static std::string AboutObjects(const std::string& query);
-
- // Renders a special page for about:dns.
- static std::string AboutDns();
-
- // Renders a special page for about:stats.
- static std::string AboutStats();
-
- // Renders a special page for "about:credits" which displays our
- // acknowledgements and legal information for code we depend on.
- static std::string AboutCredits();
-
- // Renders a special page for "about:terms" which displays our
- // terms and conditions.
- static std::string AboutTerms();
-
- // Renders a special page for about:memory which displays
- // information about current state.
- static void AboutMemory(AboutSource*, int request_id);
-
- // This displays the Linux splash screen for development releases.
- static std::string AboutLinuxSplash();
-
- private:
- ChromeURLDataManager::DataSource* about_source_;
- DISALLOW_COPY_AND_ASSIGN(BrowserAboutHandler);
-};
-
#endif // CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698