Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: chrome/browser/tab_contents/tab_contents_factory.cc

Issue 27238: Clean up some style and organization in the browser about handler. No code... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/navigation_entry.h ('k') | chrome/browser/tab_contents/tab_contents_type.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents_factory.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents_factory.cc (revision 10892)
+++ chrome/browser/tab_contents/tab_contents_factory.cc (working copy)
@@ -47,9 +47,6 @@
case TAB_CONTENTS_WEB:
contents = new WebContents(profile, instance, NULL, MSG_ROUTING_NONE, NULL);
break;
- case TAB_CONTENTS_ABOUT_UI:
- contents = new BrowserAboutHandler(profile, instance, NULL);
- break;
// TODO(port): remove this platform define, either by porting the tab contents
// types or removing them completely.
#if defined(OS_WIN)
@@ -82,6 +79,8 @@
// static
TabContentsType TabContents::TypeForURL(GURL* url) {
+ // The BrowserURLHandler::HandleBrowserURL call should just be inside the
+ // NavigationController once this class is deleted.
DCHECK(url);
if (g_extra_types) {
TabContentsFactoryMap::const_iterator it = g_extra_types->begin();
@@ -109,8 +108,7 @@
return TAB_CONTENTS_DOM_UI;
#elif defined(OS_POSIX)
TabContentsType type(TAB_CONTENTS_UNKNOWN_TYPE);
- if (BrowserURLHandler::HandleBrowserURL(url, &type) &&
- type == TAB_CONTENTS_ABOUT_UI) {
+ if (BrowserURLHandler::HandleBrowserURL(url, &type)) {
return type;
}
if (url->SchemeIs(DOMUIContents::GetScheme().c_str()))
« no previous file with comments | « chrome/browser/tab_contents/navigation_entry.h ('k') | chrome/browser/tab_contents/tab_contents_type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698