Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/tab_contents/web_contents.cc

Issue 27238: Clean up some style and organization in the browser about handler. No code... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/tab_contents/tab_contents_type.h ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/web_contents.h" 5 #include "chrome/browser/tab_contents/web_contents.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/file_version_info.h" 9 #include "base/file_version_info.h"
10 #include "base/process_util.h" 10 #include "base/process_util.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "chrome/browser/autofill_manager.h" 12 #include "chrome/browser/autofill_manager.h"
13 #include "chrome/browser/bookmarks/bookmark_model.h" 13 #include "chrome/browser/bookmarks/bookmark_model.h"
14 #include "chrome/browser/browser.h" 14 #include "chrome/browser/browser.h"
15 #include "chrome/browser/browser_about_handler.h"
15 #include "chrome/browser/dom_operation_notification_details.h" 16 #include "chrome/browser/dom_operation_notification_details.h"
16 #include "chrome/browser/download/download_manager.h" 17 #include "chrome/browser/download/download_manager.h"
17 #include "chrome/browser/gears_integration.h" 18 #include "chrome/browser/gears_integration.h"
18 #include "chrome/browser/google_util.h" 19 #include "chrome/browser/google_util.h"
19 #include "chrome/browser/js_before_unload_handler.h" 20 #include "chrome/browser/js_before_unload_handler.h"
20 #include "chrome/browser/jsmessage_box_handler.h" 21 #include "chrome/browser/jsmessage_box_handler.h"
21 #include "chrome/browser/load_from_memory_cache_details.h" 22 #include "chrome/browser/load_from_memory_cache_details.h"
22 #include "chrome/browser/load_notification_details.h" 23 #include "chrome/browser/load_notification_details.h"
23 #include "chrome/browser/password_manager/password_manager.h" 24 #include "chrome/browser/password_manager/password_manager.h"
24 #include "chrome/browser/plugin_installer.h" 25 #include "chrome/browser/plugin_installer.h"
(...skipping 1822 matching lines...) Expand 10 before | Expand all | Expand 10 after
1847 // The favicon url isn't valid. This means there really isn't a favicon, 1848 // The favicon url isn't valid. This means there really isn't a favicon,
1848 // or the favicon url wasn't obtained before the load started. This assumes 1849 // or the favicon url wasn't obtained before the load started. This assumes
1849 // the later. 1850 // the later.
1850 // TODO(sky): Need a way to set the favicon that doesn't involve generating 1851 // TODO(sky): Need a way to set the favicon that doesn't involve generating
1851 // its url. 1852 // its url.
1852 new_url->SetFavIconURL(TemplateURL::GenerateFaviconURL(params.referrer)); 1853 new_url->SetFavIconURL(TemplateURL::GenerateFaviconURL(params.referrer));
1853 } 1854 }
1854 new_url->set_safe_for_autoreplace(true); 1855 new_url->set_safe_for_autoreplace(true);
1855 url_model->Add(new_url); 1856 url_model->Add(new_url);
1856 } 1857 }
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/tab_contents_type.h ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698