chrome/test/data/extensions/samples/print_browser_action/background.html - Issue 264046: Update browser actions api to be like new design doc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/samples/print_browser_action/background.html

Issue 264046: Update browser actions api to be like new design doc. (Closed)

Patch Set: rebase Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/samples/make_page_red/background.html ('k') | chrome/test/data/extensions/samples/test_browser_action/background.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/samples/print_browser_action/background.html

diff --git a/chrome/test/data/extensions/samples/print_browser_action/background.html b/chrome/test/data/extensions/samples/print_browser_action/background.html

index 75501ea5d53b33b3f9441d1595d6dc77d3cc8962..5b3f9308dc1cc35ca5b14f5eb50703da0434534e 100644

--- a/chrome/test/data/extensions/samples/print_browser_action/background.html

+++ b/chrome/test/data/extensions/samples/print_browser_action/background.html

@@ -2,11 +2,9 @@

<head>

// Called when the user clicks on the browser action.

- chrome.browserAction.onClicked.addListener(function(windowId) {

- chrome.tabs.getSelected(windowId, function(tab) {

- var action_url = "javascript:window.print();";

- chrome.tabs.update(tab.id, {url: action_url});

- });

+ chrome.browserAction.onClicked.addListener(function(tab) {

+ var action_url = "javascript:window.print();";

+ chrome.tabs.update(tab.id, {url: action_url});

});

</script>

</head>