chrome/test/data/extensions/samples/test_browser_action/background.html - Issue 264046: Update browser actions api to be like new design doc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/samples/test_browser_action/background.html

Issue 264046: Update browser actions api to be like new design doc. (Closed)

Patch Set: rebase Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/samples/print_browser_action/background.html ('k') | chrome/test/data/extensions/samples/test_browser_action/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/samples/test_browser_action/background.html

diff --git a/chrome/test/data/extensions/samples/test_browser_action/background.html b/chrome/test/data/extensions/samples/test_browser_action/background.html

index d15d2830575ad4502e8c5fc38be02692567b9087..8170e86ce747e8bb83cfa241f13bd34032825bde 100644

--- a/chrome/test/data/extensions/samples/test_browser_action/background.html

+++ b/chrome/test/data/extensions/samples/test_browser_action/background.html

@@ -4,11 +4,11 @@

// Called when the user clicks on the browser action.

var clicks = 0;

chrome.browserAction.onClicked.addListener(function() {

- chrome.browserAction.setIcon(clicks);

+ chrome.browserAction.setIcon({iconIndex:clicks});

clicks++;

- // We only have 2 icons, but cycle through 3 icons to test the

+ // We only have 1 icon, but cycle through 3 icons to test the

// out-of-bounds index bug.

- if (clicks > 3)

+ if (clicks > 2)

clicks = 0;

});

var i = 0;

@@ -17,7 +17,7 @@

// Don't animate while in "click" mode.

if (clicks > 0) return;

i++;

- chrome.browserAction.setIcon(draw(i*2, i*4));

+ chrome.browserAction.setIcon({imageData:draw(i*2, i*4)});

}, 50);

function draw(starty, startx) {