chrome/test/data/extensions/samples/print_browser_action/background.html - Issue 264046: Update browser actions api to be like new design doc.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/samples/print_browser_action/background.html

Issue 264046: Update browser actions api to be like new design doc. (Closed)

Patch Set: rebase Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 // Called when the user clicks on the browser action.	4 // Called when the user clicks on the browser action.

5 chrome.browserAction.onClicked.addListener(function(windowId) {	5 chrome.browserAction.onClicked.addListener(function(tab) {

6 chrome.tabs.getSelected(windowId, function(tab) {	6 var action_url = "javascript:window.print();";

7 var action_url = "javascript:window.print();";	7 chrome.tabs.update(tab.id, {url: action_url});

8 chrome.tabs.update(tab.id, {url: action_url});

9 });

10 });	8 });

11 </script>	9 </script>

12 </head>	10 </head>

13 </html>	11 </html>

14	12

OLD	NEW