Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/extensions/samples/make_page_red/background.html

Issue 264046: Update browser actions api to be like new design doc. (Closed)
Patch Set: rebase Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/samples/gmail_browser_action/background.html ('k') | chrome/test/data/extensions/samples/print_browser_action/background.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/samples/make_page_red/background.html
diff --git a/chrome/test/data/extensions/samples/make_page_red/background.html b/chrome/test/data/extensions/samples/make_page_red/background.html
index 30631d23222de858687dfc6bb05fec2ffe9bd928..5e348e7f86d40826040c32cd4c04f8744297d1bb 100755
--- a/chrome/test/data/extensions/samples/make_page_red/background.html
+++ b/chrome/test/data/extensions/samples/make_page_red/background.html
@@ -2,15 +2,15 @@
<head>
<script>
// Called when the user clicks on the browser action.
- chrome.browserAction.onClicked.addListener(function(windowId) {
+ chrome.browserAction.onClicked.addListener(function(tab) {
chrome.tabs.executeScript(null, {code:"document.body.bgColor='red'"});
});
- chrome.browserAction.setBadgeBackgroundColor([100, 0, 200, 0]);
+ chrome.browserAction.setBadgeBackgroundColor({color:[100, 0, 200, 0]});
var i = 0;
window.setInterval(function() {
- chrome.browserAction.setBadgeText(String(i));
+ chrome.browserAction.setBadgeText({text:String(i)});
i++;
}, 10);
</script>
« no previous file with comments | « chrome/test/data/extensions/samples/gmail_browser_action/background.html ('k') | chrome/test/data/extensions/samples/print_browser_action/background.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698