|
First pass at experimental omnibox API. There are plenty of rough edges and features to work on, but it's in a usable state.
When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later.
I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout
the omnibox code.
BUG= 38884
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48503
Total comments: 54
Total comments: 23
Total comments: 7
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+801 lines, -99 lines) |
Patch |
|
M |
chrome/app/generated_resources.grd
|
View
|
1
2
3
4
5
6
|
3 chunks |
+15 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/autocomplete_edit.cc
|
View
|
1
2
|
3 chunks |
+19 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/keyword_provider.h
|
View
|
1
2
3
4
5
6
7
|
4 chunks |
+28 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/keyword_provider.cc
|
View
|
1
2
3
4
5
6
7
8
|
11 chunks |
+128 lines, -19 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/location_bar_view_mac.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/location_bar_view_mac.mm
|
View
|
1
|
5 chunks |
+12 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/location_bar_view_mac_unittest.mm
|
View
|
1
|
3 chunks |
+9 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_function_dispatcher.cc
|
View
|
1
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_message_service.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_message_service.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/extensions/extension_omnibox_api.h
|
View
|
1
2
3
4
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/extensions/extension_omnibox_api.cc
|
View
|
1
2
3
4
|
1 chunk |
+67 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/extensions/extension_omnibox_apitest.cc
|
View
|
|
1 chunk |
+134 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extensions_service.h
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extensions_service.cc
|
View
|
1
|
5 chunks |
+13 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/gtk/location_bar_view_gtk.cc
|
View
|
1
|
3 chunks |
+13 lines, -19 lines |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url.h
|
View
|
1
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url.cc
|
View
|
1
|
3 chunks |
+11 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url_model.h
|
View
|
1
|
5 chunks |
+25 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url_model.cc
|
View
|
1
|
7 chunks |
+74 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url_table_model.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/views/location_bar/keyword_hint_view.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/views/location_bar/keyword_hint_view.cc
|
View
|
|
2 chunks |
+6 lines, -16 lines |
0 comments
|
Download
|
|
M |
chrome/browser/views/location_bar/selected_keyword_view.cc
|
View
|
|
2 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
1
2
3
4
5
6
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
3
4
5
6
7
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/extensions/api/extension_api.json
|
View
|
1
2
|
1 chunk |
+67 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/common/extensions/docs/examples/api/omnibox/background.html
|
View
|
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/common/extensions/docs/examples/api/omnibox/manifest.json
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/extensions/docs/experimental.html
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/extensions/extension.h
|
View
|
1
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/extensions/extension.cc
|
View
|
1
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/extensions/extension_constants.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/extensions/extension_constants.cc
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/notification_type.h
|
View
|
1
2
3
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/resources/extension_apitest.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/renderer/resources/extension_process_bindings.js
|
View
|
1
|
2 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/resources/renderer_extension_bindings.js
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
A |
chrome/test/data/extensions/api_test/omnibox/manifest.json
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/test/data/extensions/api_test/omnibox/test.html
|
View
|
|
1 chunk |
+23 lines, -0 lines |
0 comments
|
Download
|
Total messages: 21 (0 generated)
|