Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3833)

Unified Diff: chrome/browser/gtk/location_bar_view_gtk.cc

Issue 2078021: First pass at experimental omnibox API. There are plenty of rough edges and (Closed)
Patch Set: no prefer_keyword Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_service.cc ('k') | chrome/browser/search_engines/template_url.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/location_bar_view_gtk.cc
diff --git a/chrome/browser/gtk/location_bar_view_gtk.cc b/chrome/browser/gtk/location_bar_view_gtk.cc
index 2a2e571b90f2f114af80e127e82fb38b39d41f17..9eb2257cad2e978f04537dfd3100c9e6abd9b885 100644
--- a/chrome/browser/gtk/location_bar_view_gtk.cc
+++ b/chrome/browser/gtk/location_bar_view_gtk.cc
@@ -94,19 +94,6 @@ const GdkColor kHintTextColor = GDK_COLOR_RGB(0x75, 0x75, 0x75);
// Size of the rounding of the "Search site for:" box.
const int kCornerSize = 3;
-// Returns the short name for a keyword.
-std::wstring GetKeywordName(Profile* profile,
- const std::wstring& keyword) {
- // Make sure the TemplateURL still exists.
- // TODO(sky): Once LocationBarView adds a listener to the TemplateURLModel
- // to track changes to the model, this should become a DCHECK.
- const TemplateURL* template_url =
- profile->GetTemplateURLModel()->GetTemplateURLForKeyword(keyword);
- if (template_url)
- return template_url->AdjustedShortNameForLocaleDirection();
- return std::wstring();
-}
-
// If widget is visible, increment the int pointed to by count.
// Suitible for use with gtk_container_foreach.
void CountVisibleWidgets(GtkWidget* widget, gpointer count) {
@@ -905,11 +892,14 @@ void LocationBarViewGtk::SetKeywordLabel(const std::wstring& keyword) {
if (!profile_->GetTemplateURLModel())
return;
- const std::wstring short_name = GetKeywordName(profile_, keyword);
- std::wstring full_name(l10n_util::GetStringF(
- IDS_OMNIBOX_KEYWORD_TEXT, short_name));
+ bool is_extension_keyword;
+ const std::wstring short_name = profile_->GetTemplateURLModel()->
+ GetKeywordShortName(keyword, &is_extension_keyword);
+ int message_id = is_extension_keyword ?
+ IDS_OMNIBOX_EXTENSION_KEYWORD_TEXT : IDS_OMNIBOX_KEYWORD_TEXT;
+ std::wstring full_name(l10n_util::GetStringF(message_id, short_name));
std::wstring partial_name(l10n_util::GetStringF(
- IDS_OMNIBOX_KEYWORD_TEXT, CalculateMinString(short_name)));
+ message_id, CalculateMinString(short_name)));
gtk_label_set_text(GTK_LABEL(tab_to_search_full_label_),
WideToUTF8(full_name).c_str());
gtk_label_set_text(GTK_LABEL(tab_to_search_partial_label_),
@@ -924,10 +914,14 @@ void LocationBarViewGtk::SetKeywordHintLabel(const std::wstring& keyword) {
if (!profile_->GetTemplateURLModel())
return;
+ bool is_extension_keyword;
+ const std::wstring short_name = profile_->GetTemplateURLModel()->
+ GetKeywordShortName(keyword, &is_extension_keyword);
+ int message_id = is_extension_keyword ?
+ IDS_OMNIBOX_EXTENSION_KEYWORD_HINT : IDS_OMNIBOX_KEYWORD_HINT;
std::vector<size_t> content_param_offsets;
const std::wstring keyword_hint(l10n_util::GetStringF(
- IDS_OMNIBOX_KEYWORD_HINT, std::wstring(),
- GetKeywordName(profile_, keyword), &content_param_offsets));
+ message_id, std::wstring(), short_name, &content_param_offsets));
if (content_param_offsets.size() != 2) {
// See comments on an identical NOTREACHED() in search_provider.cc.
« no previous file with comments | « chrome/browser/extensions/extensions_service.cc ('k') | chrome/browser/search_engines/template_url.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698