Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 193072: Move StringPiece into the base namespace. It is colliding (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google, agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move StringPiece into the base namespace. It is colliding with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu.

Patch Set 1 #

Patch Set 2 : take 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -158 lines) Patch
M app/resource_bundle.h View 2 chunks +3 lines, -1 line 0 comments Download
M app/resource_bundle_linux.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M app/resource_bundle_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M app/resource_bundle_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/data_pack.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/data_pack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug_util_posix.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/file_path.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/file_path.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/string_piece.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/string_piece.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M base/string_piece_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/string_util.h View 4 chunks +5 lines, -5 lines 0 comments Download
M base/string_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/string_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_string_conversions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/print_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_pref_extension_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/privacy_blacklist/blocked_response.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/sync/sync_setup_wizard.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/user_script.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/jstemplate_builder.h View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/jstemplate_builder.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/user_script_slave.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/user_script_slave.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/v8_unit_test.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/v8_unit_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_module.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/registry_controlled_domain.h View 5 chunks +7 lines, -6 lines 0 comments Download
M net/base/registry_controlled_domain.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M net/http/http_chunked_decoder.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/devtools/debugger_agent_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/glue/webkit_glue.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/test_worker/test_worker_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
I will also roll hunspell deps once http://codereview.chromium.org/193073 lands.
11 years, 3 months ago (2009-09-10 18:30:01 UTC) #1
agl
If the try bots like it: LGTM
11 years, 3 months ago (2009-09-10 18:31:40 UTC) #2
jungshik at Google
11 years, 3 months ago (2009-09-10 20:58:20 UTC) #3
On 2009/09/10 18:31:40, agl wrote:
> If the try bots like it: LGTM

same here :-)

Thanks for the CL !

Powered by Google App Engine
This is Rietveld 408576698