chrome/tools/mac_helpers/infoplist_strings_util.mm - Issue 193072: Move StringPiece into the base namespace. It is colliding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/mac_helpers/infoplist_strings_util.mm

Issue 193072: Move StringPiece into the base namespace. It is colliding (Closed)

Patch Set: take 2 Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/mac_helpers/infoplist_strings_util.mm

diff --git a/chrome/tools/mac_helpers/infoplist_strings_util.mm b/chrome/tools/mac_helpers/infoplist_strings_util.mm

index f2bbf7a738f524c9b80a7b110f04cc5b74099b09..fbdc924be3654b4cc62332cc3fba2b9b183b789f 100644

--- a/chrome/tools/mac_helpers/infoplist_strings_util.mm

+++ b/chrome/tools/mac_helpers/infoplist_strings_util.mm

@@ -76,7 +76,7 @@ NSString* LoadStringFromDataPack(base::DataPack* data_pack,

uint32_t resource_id,

const char* resource_id_str) {

NSString* result = nil;

- StringPiece data;

+ base::StringPiece data;

if (data_pack->Get(resource_id, &data)) {

// Data pack encodes strings as UTF16.

result =

« no previous file with comments | « chrome/test/v8_unit_test.cc ('k') | net/base/net_module.h » ('j') | no next file with comments »